From 1799ebd592918408524a7f3ce814e3307e0b0b23 Mon Sep 17 00:00:00 2001 From: John Doe Date: Fri, 25 Sep 2020 16:33:16 +0000 Subject: [PATCH] Bug 26351: Add unit tests --- t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t | 3 +++ t/db_dependent/Koha/Plugins/Circulation_hooks.t | 1 + t/lib/Koha/Plugin/Test.pm | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t index 44f68ee87f..af49ef9563 100755 --- a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t +++ b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t @@ -52,6 +52,9 @@ subtest 'after_biblio_action() and after_item_action() hooks tests' => sub { my $plugin = Koha::Plugin::Test->new->enable; + my $test_plugin = Test::MockModule->new('Koha::Plugin::Test'); + $test_plugin->mock( 'barcode_transform', undef ); + my $biblio_id; warning_like { ( $biblio_id, undef ) = C4::Biblio::AddBiblio( MARC::Record->new(), '' ); } diff --git a/t/db_dependent/Koha/Plugins/Circulation_hooks.t b/t/db_dependent/Koha/Plugins/Circulation_hooks.t index 5f8569d9ed..c7ca3030bf 100755 --- a/t/db_dependent/Koha/Plugins/Circulation_hooks.t +++ b/t/db_dependent/Koha/Plugins/Circulation_hooks.t @@ -66,6 +66,7 @@ subtest 'after_circ_action() hook tests' => sub { my $test_plugin = Test::MockModule->new('Koha::Plugin::Test'); $test_plugin->mock( 'after_item_action', undef ); $test_plugin->mock( 'after_biblio_action', undef ); + $test_plugin->mock( 'barcode_transform', undef ); my $biblio = $builder->build_sample_biblio(); my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ); diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm index a8cf2a5915..18767dc295 100644 --- a/t/lib/Koha/Plugin/Test.pm +++ b/t/lib/Koha/Plugin/Test.pm @@ -95,7 +95,7 @@ sub intranet_js { sub barcode_transform { my ( $self, $type, $barcode ) = @_; - return "Koha::Plugin::Test::barcode_transform"; + Koha::Exceptions::Exception->throw("barcode_transform called with parameters: $type, $barcode"); } sub barcode_generate { -- 2.24.1 (Apple Git-126)