Bugzilla – Attachment 111065 Details for
Bug 7607
Advanced search: Index and search term don't match when leaving fields empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7607: (QA follow-up) Add comment line to new submit action
Bug-7607-QA-follow-up-Add-comment-line-to-new-subm.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2020-10-02 08:04:56 UTC
(
hide
)
Description:
Bug 7607: (QA follow-up) Add comment line to new submit action
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-10-02 08:04:56 UTC
Size:
1.79 KB
patch
obsolete
>From 4446e5f4c7ca3dfd423d86898f2a840dcf7dc9d9 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 2 Oct 2020 08:00:14 +0000 >Subject: [PATCH] Bug 7607: (QA follow-up) Add comment line to new submit > action >Content-Type: text/plain; charset=utf-8 > >The solution here is a workaround, but we need to document why >we are doing this. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 1 + > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index b993cd0859..4902d92b9a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -345,6 +345,7 @@ > [% END %] > > $("#adv-search-form").on("submit", function(){ >+ // Prevent searching on the wrong index by clearing selects > var idx = $("select[name='idx']"); > var i = 0; > $("input[name='q']").each(function(){ >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index 7efd9b193c..0d50217551 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -505,6 +505,7 @@ $(document).ready(function() { > > var i = 0; > $("input[name='q']").each(function(){ >+ // Prevent searching on the wrong index by clearing selects > if( !$(this).val().length ) { > $("#search-field_"+i).val(""); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7607
:
107963
|
110845
|
110849
|
111064
|
111065
|
112912
|
112963
|
112964
|
113133
|
113134
|
113682
|
113683
|
113691
|
113692
|
113781
|
113872
|
113873
|
113874