From 2adc0e9857fb17e5ed5f8c56feddf523a4e1f76d Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Thu, 8 Oct 2020 15:34:08 +0000 Subject: [PATCH] Bug 26634: Do not reorder effective rules To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Lisette Scheer --- C4/Reserves.pm | 6 ------ 1 file changed, 6 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 2422d4facd..8272c771c2 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -2245,9 +2245,6 @@ sub GetHoldRule { categorycode => $categorycode, branchcode => $branchcode, rule_name => 'reservesallowed', - order_by => { - -desc => [ 'categorycode', 'itemtype', 'branchcode' ] - } } ); @@ -2265,9 +2262,6 @@ sub GetHoldRule { categorycode => $categorycode, branchcode => $branchcode, rules => ['holds_per_record', 'holds_per_day'], - order_by => { - -desc => [ 'categorycode', 'itemtype', 'branchcode' ] - } } ); $rules->{holds_per_record} = $holds_per_x_rules->{holds_per_record}; -- 2.11.0