Bugzilla – Attachment 111411 Details for
Bug 26635
Expand coded values in REST API call
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26635: Add tests
Bug-26635-Add-tests.patch (text/plain), 3.09 KB, created by
Agustín Moyano
on 2020-10-09 14:56:00 UTC
(
hide
)
Description:
Bug 26635: Add tests
Filename:
MIME Type:
Creator:
Agustín Moyano
Created:
2020-10-09 14:56:00 UTC
Size:
3.09 KB
patch
obsolete
>From 6636f4cacbb0af35d083cd08724ec2546eecb951 Mon Sep 17 00:00:00 2001 >From: Agustin Moyano <agustinmoyano@theke.io> >Date: Fri, 9 Oct 2020 09:59:46 -0300 >Subject: [PATCH] Bug 26635: Add tests > >Add tests in t/db_dependent/Koha/Object.t >--- > t/db_dependent/Koha/Object.t | 43 +++++++++++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index cae049cbd2..7322666fb5 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 20; >+use Test::More tests => 21; > use Test::Exception; > use Test::Warn; > use DateTime; >@@ -33,6 +33,8 @@ use Koha::DateUtils qw( dt_from_string ); > use Koha::Libraries; > use Koha::Patrons; > use Koha::ApiKeys; >+use Koha::AuthorisedValueCategories; >+use Koha::AuthorisedValues; > > use JSON; > use Scalar::Util qw( isvstring ); >@@ -867,3 +869,42 @@ subtest 'set_or_blank' => sub { > > $schema->storage->txn_rollback; > }; >+ >+subtest 'Authorised values expansion' => sub { >+ plan tests => 4; >+ >+ $schema->storage->txn_begin; >+ >+ Koha::AuthorisedValues->search({category => 'Countries'})->delete; >+ Koha::AuthorisedValueCategories->search({category_name =>'Countries'})->delete; >+ >+ my $cat = $builder->build_object({ class => 'Koha::AuthorisedValueCategories', value => {category_name =>'Countries'} }); >+ my $fr = $builder->build_object({ class => 'Koha::AuthorisedValues', value => {authorised_value => 'FR', lib=>'France', category=>$cat->category_name} }); >+ my $us = $builder->build_object({ class => 'Koha::AuthorisedValues', value => {authorised_value => 'US', lib=>'United States of America', category=>$cat->category_name} }); >+ my $ar = $builder->build_object({ class => 'Koha::AuthorisedValues', value => {authorised_value => 'AR', lib=>'Argentina', category=>$cat->category_name} }); >+ >+ my $city_class = Test::MockModule->new('Koha::City'); >+ $city_class->mock( '_fetch_authorised_values', >+ sub { >+ my ($self) = @_; >+ use Koha::AuthorisedValues; >+ my $av = Koha::AuthorisedValues->find({authorised_value => $self->city_country, category => 'Countries'}); >+ return {country => $av->unblessed}; >+ } >+ ); >+ >+ my $marseille = $builder->build_object({ class => 'Koha::Cities', value => {city_country => 'FR', city_name => 'Marseille'} }); >+ my $cordoba = $builder->build_object({ class => 'Koha::Cities', value => {city_country => 'AR', city_name => 'Córdoba'} }); >+ >+ my $mobj = $marseille->to_api({av_expand => 1}); >+ my $cobj = $cordoba->to_api({av_expand => 1}); >+ >+ isnt($mobj->{_authorised_values}, undef, '_authorised_values exists for Marseille'); >+ isnt($cobj->{_authorised_values}, undef, '_authorised_values exists for Córdoba'); >+ >+ is($mobj->{_authorised_values}->{country}->{lib}, $fr->lib, 'Authorised value for country expanded'); >+ is($cobj->{_authorised_values}->{country}->{lib}, $ar->lib, 'Authorised value for country expanded'); >+ >+ >+ $schema->storage->txn_rollback; >+}; >\ No newline at end of file >-- >2.25.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26635
:
111400
|
111401
|
111402
|
111411
|
111412
|
111413
|
111414
|
112538
|
112539
|
116232
|
116233
|
116234
|
116235
|
116592
|
116593
|
120698
|
120699
|
120700
|
124268
|
142761
|
142762
|
142763
|
142776
|
142792
|
142793
|
142794
|
142795
|
142796
|
142801
|
142802
|
142803
|
142804
|
142805
|
143039
|
143040
|
143041
|
143042
|
143043
|
143044
|
143073
|
143074
|
143075
|
143076
|
143077
|
143078
|
143079
|
143080
|
143127
|
143128
|
143129
|
143130
|
143131
|
143132
|
143133
|
143134
|
143276
|
143354
|
143355
|
143356
|
143357
|
143358
|
143359
|
143360
|
143361
|
143362