From f9bef9832a9020f28baaa5b72174c13f9423e5d7 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 5 Aug 2020 17:50:39 +0000
Subject: [PATCH] Bug 26152: Remove the use of jquery.checkboxes plugin from
 serial collection page

This patch removes the use of the jquery.checkboxes plugin from the
serial collection page and replaces it with custom JS.

To test, apply the patch and go to Serials.

- Locate a subscription which has multiple issues.
- View the details for that subscription.
- In the sidebar menu click the "Serial collection" link.
- On the serial collection page test the "Select all" and "Clear all"
  links at the top of each table of issues. The controls should work
  correctly and only affect the table on  that tab.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
---
 .../intranet-tmpl/prog/en/modules/serials/serials-collection.tt      | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
index 46ad031166..1aa688293a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
@@ -307,7 +307,6 @@
         var subscriptionid = "[% subscriptionid | html %]";
     </script>
     [% Asset.js("js/serials-toolbar.js") | $raw %]
-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
 
     <script>
 
@@ -348,13 +347,13 @@
             $(".CheckAll").on("click", function(e){
                 e.preventDefault();
                 var years = $(this).data("year");
-                $("#subscription-year-" + years ).checkCheckboxes();
+                $("#subscription-year-" + years + " input:checkbox").prop("checked", true );
             });
 
             $(".CheckNone").on("click", function(e){
                 e.preventDefault();
                 var years = $(this).data("year");
-                $("#subscription-year-" + years ).unCheckCheckboxes();
+                $("#subscription-year-" + years + " input:checkbox").prop("checked", false );
             });
 
             $(".generatenext").on("click", function(e){
-- 
2.11.0