From 13ccc27987f70153cc40b80791682a303ea8fae3 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 23 Sep 2020 16:14:55 +0000 Subject: [PATCH] Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer --- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 13 +++++++++++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 7 +++---- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- 4 files changed, 19 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 615c9a05d8..c78024c9f5 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -16,6 +16,8 @@ #sortsubmit { display: inline; + padding-left: 0; + padding-right: 0; } } @@ -1337,6 +1339,17 @@ nav { margin: .3em 0; } +.ui-widget-content { + a { + &:link, + &:visited { + &.btn { + color: #FFF; + } + } + } +} + #social_networks { margin-top: .5em; diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 2854660887..d566d4c04b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -796,9 +796,9 @@