From c638a83e8f9ec275d5a66e18909080642de9afed Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Tue, 13 Oct 2020 10:09:37 +0200 Subject: [PATCH] Bug 24679: Return the correct id in AddModificationTemplate 'name' is not unique, and should not be used to retrieve the last inserted id --- C4/MarcModificationTemplates.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/C4/MarcModificationTemplates.pm b/C4/MarcModificationTemplates.pm index 50d26a04ae..ded03f2fc8 100644 --- a/C4/MarcModificationTemplates.pm +++ b/C4/MarcModificationTemplates.pm @@ -107,10 +107,7 @@ sub AddModificationTemplate { my $sth = $dbh->prepare("INSERT INTO marc_modification_templates ( name ) VALUES ( ? )"); $sth->execute( $template_name ); - $sth = $dbh->prepare("SELECT * FROM marc_modification_templates WHERE name = ?"); - $sth->execute( $template_name ); - my $row = $sth->fetchrow_hashref(); - my $template_id = $row->{'template_id'}; + my $template_id = $dbh->last_insert_id(undef, undef, 'marc_modification_templates'); if ( $template_id_copy ) { my @actions = GetModificationTemplateActions( $template_id_copy ); -- 2.20.1