Bugzilla – Attachment 111589 Details for
Bug 25898
Prohibit indirect object notation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25898: (follow-up) POD
Bug-25898-follow-up-POD.patch (text/plain), 1.28 KB, created by
Katrin Fischer
on 2020-10-14 10:57:39 UTC
(
hide
)
Description:
Bug 25898: (follow-up) POD
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-10-14 10:57:39 UTC
Size:
1.28 KB
patch
obsolete
>From bc55c25a0260be0f7bd504143567538fb9122702 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 7 Oct 2020 14:33:19 -0300 >Subject: [PATCH] Bug 25898: (follow-up) POD > >Our docs shouldn't suggest indirect object notation is accepted or >encouraged. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Auth.pm | 2 +- > C4/Context.pm | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index adfd18c9af..51018f3b7b 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -93,7 +93,7 @@ C4::Auth - Authenticates Koha users > use C4::Auth; > use C4::Output; > >- my $query = new CGI; >+ my $query = CGI->new; > > my ($template, $borrowernumber, $cookie) > = get_template_and_user( >diff --git a/C4/Context.pm b/C4/Context.pm >index 58a6ad5e05..2dab73e9d1 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -211,8 +211,8 @@ sub import { > > =head2 new > >- $context = new C4::Context; >- $context = new C4::Context("/path/to/koha-conf.xml"); >+ $context = C4::Context->new; >+ $context = C4::Context->new("/path/to/koha-conf.xml"); > > Allocates a new context. Initializes the context from the specified > file, which defaults to either the file given by the C<$KOHA_CONF> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25898
:
106423
|
111351
|
111352
|
111588
| 111589 |
111714
|
112525