From 6d06340cda5e4c74e325740e2f30510f9b619888 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 16 Oct 2020 16:13:32 +0000
Subject: [PATCH] Bug 19482: (follow-up) Don't set readonly as a variable, use
 conditionals

---
 .../admin/searchengine/elasticsearch/mappings.tt     | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
index ed2e5229a1..8eb5b9675b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
@@ -183,19 +183,23 @@ a.add, a.delete {
                 </thead>
                 <tbody>
                   [% FOREACH search_field IN all_search_fields %]
-                      [% IF search_field.mandatory %]
-                          [% SET is_readonly = "readonly" %]
-                      [% ELSE %]
-                          [% SET is_readonly = "" %]
-                      [% END %]
                     <tr>
                       <td>
-                        <input type="text" name="search_field_name" value="[% search_field.name | html %]" [% is_readonly | html %]/>
+                        [% IF search_field.mandatory %]
+                            <input type="text" name="search_field_name" value="[% search_field.name | html %]" readonly />
+                        [% ELSE %]
+                            <input type="text" name="search_field_name" value="[% search_field.name | html %]" />
+                        [% END %]
                       </td>
                       <td>
-                        <input type="text" name="search_field_label" value="[% search_field.label | html %]" [% is_readonly | html %]/>
+                        [% IF search_field.mandatory %]
+                            <input type="text" name="search_field_label" value="[% search_field.label | html %]" readonly />
+                        [% ELSE %]
+                            <input type="text" name="search_field_label" value="[% search_field.label | html %]" />
+                        [% END %]
+
                       <td>
-                        [% IF is_readonly %]
+                        [% IF search_field.mandatory %]
                             <input type="hidden" name="search_field_type" value="[% search_field.type | html %]" />
                             <select name="search_field_type" disabled>
                         [% ELSE %]
-- 
2.11.0