Bugzilla – Attachment 11199 Details for
Bug 8522
Markup errors cause problems with customized CSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8522 - Markup errors cause problems with customized CSS
Bug-8522---Markup-errors-cause-problems-with-custo.patch (text/plain), 4.64 KB, created by
Owen Leonard
on 2012-07-30 15:01:14 UTC
(
hide
)
Description:
Bug 8522 - Markup errors cause problems with customized CSS
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-07-30 15:01:14 UTC
Size:
4.64 KB
patch
obsolete
>From f247fb7ca8c6546876f40b23b47a5a37b98014fc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 30 Jul 2012 10:43:55 -0400 >Subject: [PATCH] Bug 8522 - Markup errors cause problems with customized CSS >Content-Type: text/plain; charset="utf-8" > >Some includes and templates contained duplicate "header" ids in >the markup. The problem should have come up in routine page >validation, but was obvious when custom CSS was applied. > >To test, load any of the affected pages and validate the >generated HTML. There should be no errors about 'ID "header" >already defined." Or, add custom CSS to intranetusercss: > >...and confirm that only the topmost menu background is affected. >--- > .../prog/en/includes/budgets-admin-search.inc | 2 +- > .../prog/en/includes/cities-admin-search.inc | 2 +- > .../prog/en/includes/patrons-admin-search.inc | 2 +- > .../prog/en/includes/roadtype-admin-search.inc | 3 +-- > .../prog/en/includes/z3950-admin-search.inc | 2 +- > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 3 +-- > 6 files changed, 6 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc >index 0b70028..b99c52a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc >@@ -1,4 +1,4 @@ >-<div id="header" class="gradient"> >+<div class="gradient"> > <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Fund Admin Resident Search Box --> > > <div id="header_search"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc >index cc46780..191f7f3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc >@@ -1,4 +1,4 @@ >-<div id="header" class="gradient"> >+<div class="gradient"> > <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Cities Resident Search Box --> > <div id="header_search"> > <div id="city_search" class="residentsearch"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc >index 65d0aef..3fd9f5d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc >@@ -1,4 +1,4 @@ >-<div id="header" class="gradient"> >+<div class="gradient"> > <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Patrons Admin Resident Search Box --> > <div id="header_search"> > <div id="patron_category_search" class="residentsearch"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc >index 21a83ab..f7bb425 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc >@@ -1,5 +1,4 @@ >- >-<div id="header" class="gradient"> >+<div class="gradient"> > <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Roads Resident Search Box --> > <div id="header_search"> > <div id="roadtype_search" class="residentsearch ui-tabs-panel"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc >index 94190ea..da47e19 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc >@@ -1,4 +1,4 @@ >-<div id="header" class="gradient"> >+<div class="gradient"> > <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin z3950 Admin Resident Search Box --> > <div id="header_search"> > <div id="z3950_search" class="residentsearch"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 1ed01f0..78f1e4b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -47,10 +47,9 @@ $(document).ready(function () { > </script> > </head> > <body id="circ_returns" class="circ"> >-<div id="header" class="gradient"> >+ > [% INCLUDE 'header.inc' %] > [% INCLUDE 'checkin-search.inc' %] >-</div> > > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/circ/circulation-home.pl">Circulation</a> › Check in</div> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8522
:
11198
|
11199
|
11396