Bugzilla – Attachment 112111 Details for
Bug 21811
Add warning when order receive form is saved without entering 'quantity received'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21811: Add JS confirmation when receiving - at least 1 item to receive
Bug-21811-Add-JS-confirmation-when-receiving---at-.patch (text/plain), 1.55 KB, created by
Martin Renvoize
on 2020-10-21 15:45:45 UTC
(
hide
)
Description:
Bug 21811: Add JS confirmation when receiving - at least 1 item to receive
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-10-21 15:45:45 UTC
Size:
1.55 KB
patch
obsolete
>From e401e252da0a5aeeeaa9e26c03f4c48cd3051c7f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 31 Jul 2020 10:21:27 +0200 >Subject: [PATCH] Bug 21811: Add JS confirmation when receiving - at least 1 > item to receive >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When receiving, the "receive items" form should not be submitted if no >items are going to be received > >Test plan: >Create an order, close the basket, receive some items >On the "receive items" form, do not select item (if items are created >when placing the order) and submit the form >=> You must get a JS alert that prevent the form to be submitted >Select at least one item, submit again >=> Now it's submitted > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 4dac82afd1..578a08ae65 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -429,6 +429,11 @@ > }; > [% END %] > >+ if( $("#quantity").val() < 1 ) { >+ alert(_("You must receive at least one item")); >+ return false; >+ } >+ > return true; > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21811
:
107619
|
112055
| 112111