Bugzilla – Attachment 11249 Details for
Bug 8533
Non-numeric cardnumbers screw up autoMemberNum
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum
Bug-8533---Non-numeric-cardnumbers-screw-up-autoMe.patch (text/plain), 1.18 KB, created by
Jonathan Druart
on 2012-08-01 12:12:07 UTC
(
hide
)
Description:
Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-08-01 12:12:07 UTC
Size:
1.18 KB
patch
obsolete
>From 555b042d2edc075597a3a9def4774e11ef85a48f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 31 Jul 2012 08:14:19 -0400 >Subject: [PATCH] Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Removes a warning from mysql: > Truncated incorrect INTEGER value: 'P13000' >--- > C4/Members.pm | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 2e59c91..2e315aa 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -899,11 +899,8 @@ sub fixup_cardnumber { > return "V$cardnumber$rem"; > } else { > >- # MODIFIED BY JF: mysql4.1 allows casting as an integer, which is probably >- # better. I'll leave the original in in case it needs to be changed for you >- # my $sth=$dbh->prepare("select max(borrowers.cardnumber) from borrowers"); > my $sth = $dbh->prepare( >- "select max(cast(cardnumber as signed)) from borrowers" >+ 'SELECT MAX( CAST( cardnumber AS SIGNED ) ) FROM borrowers WHERE cardnumber REGEXP "^-?[0-9]+$"' > ); > $sth->execute; > my ($result) = $sth->fetchrow; >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8533
:
11217
|
11221
| 11249