Bugzilla – Attachment 11261 Details for
Bug 8532
Old/iffy data causes error checking out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8532 - improve robustness when converting dates
Bug-8532---improve-robustness-when-converting-date.patch (text/plain), 1.63 KB, created by
Jonathan Druart
on 2012-08-01 14:23:12 UTC
(
hide
)
Description:
Bug 8532 - improve robustness when converting dates
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-08-01 14:23:12 UTC
Size:
1.63 KB
patch
obsolete
>From d9b3c0e972af67194665c5e9ab0bcd4252a49c57 Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Tue, 31 Jul 2012 13:22:48 +0200 >Subject: [PATCH] Bug 8532 - improve robustness when converting dates > >If undef is passed to the date format conversion function, it dies. This >can happen when you have old data in the database. Better to handle it >in some fashion rather than die, so now it just returns undef too. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >I replace "return undef" with just "return" to pass perlcritic >--- > Koha/DateUtils.pm | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > >diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm >index a1fd088..d7892dd 100644 >--- a/Koha/DateUtils.pm >+++ b/Koha/DateUtils.pm >@@ -94,7 +94,8 @@ s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/; > > $date_string = output_pref($dt, [$format] ); > >-Returns a string containing the time & date formatted as per the C4::Context setting >+Returns a string containing the time & date formatted as per the C4::Context setting, >+or C<undef> if C<undef> was provided. > > A second parameter allows overriding of the syspref value. This is for testing only > In usage use the DateTime objects own methods for non standard formatting >@@ -104,6 +105,9 @@ In usage use the DateTime objects own methods for non standard formatting > sub output_pref { > my $dt = shift; > my $force_pref = shift; # if testing we want to override Context >+ >+ return unless defined $dt; >+ > my $pref = > defined $force_pref ? $force_pref : C4::Context->preference('dateformat'); > given ($pref) { >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8532
:
11216
| 11261