Bugzilla – Attachment 112661 Details for
Bug 26696
Make payment table has a display issue when credits exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26696: Fix colspan in payment table when credit exists
Bug-26696-Fix-colspan-in-payment-table-when-credit.patch (text/plain), 1.93 KB, created by
David Nind
on 2020-10-29 09:40:32 UTC
(
hide
)
Description:
Bug 26696: Fix colspan in payment table when credit exists
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-10-29 09:40:32 UTC
Size:
1.93 KB
patch
obsolete
>From b7bf970b4a56cdcceb78b132c4e737f770b50e40 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 16 Oct 2020 01:23:41 +0200 >Subject: [PATCH] Bug 26696: Fix colspan in payment table when credit exists > >The colspan was adjusted for the total due when a new column >was added to the table, but the 2 lines for credits were missed. > >To test: >- Go to any patron account >- Create a manual invoice >- Create a credit >- Go to the 'Make a payment' tab >- Veriy that the total lines at the bottom of the table are > slightly off >- Apply the patch >- Verify that the total lines in the table now display correctly > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index c66aecbf2d..f42ad63774 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -135,11 +135,11 @@ > </tr> > [% IF outstanding_credits.total_outstanding < 0 %] > <tr> >- <td class="total" colspan="11">Outstanding credits could be applied: </td> >+ <td class="total" colspan="12">Outstanding credits could be applied: </td> > <td class="credit" style="text-align: right;"><button type="submit" id="apply_credits" name="apply_credits" value="apply_credits" class="btn btn-default btn-sm">Apply <strong class="credit">[% outstanding_credits.total_outstanding | $Price %]</strong></button></td> > </tr> > <tr> >- <td class="total" colspan="11">Total due if credit applied:</td> >+ <td class="total" colspan="12">Total due if credit applied:</td> > <td style="text-align: right;">[% total + outstanding_credits.total_outstanding | $Price %]</td> > </tr> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26696
:
111775
|
111818
|
112661
|
112860