From e8c30509dd37115f73abb4847df4112b0f5a8fb9 Mon Sep 17 00:00:00 2001
From: Agustin Moyano <agustinmoyano@theke.io>
Date: Sun, 9 Feb 2020 17:53:55 -0300
Subject: [PATCH] Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 installer/data/mysql/atomicupdate/bug-20936.perl       | 10 ++++++++++
 installer/data/mysql/mandatory/sysprefs.sql            |  1 +
 .../prog/en/modules/admin/preferences/opac.pref        |  6 ++++++
 3 files changed, 17 insertions(+)
 create mode 100644 installer/data/mysql/atomicupdate/bug-20936.perl

diff --git a/installer/data/mysql/atomicupdate/bug-20936.perl b/installer/data/mysql/atomicupdate/bug-20936.perl
new file mode 100644
index 0000000000..6fec956b08
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug-20936.perl
@@ -0,0 +1,10 @@
+$DBversion = 'XXX';
+if( CheckVersion( $DBversion ) ) {
+
+    $dbh->do(qq{
+        INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
+        ('OPACHoldsHistory','0','','If ON, enables display of Patron Holds History in OPAC','YesNo')
+    });
+
+    NewVersion( $DBversion, 20936, "Add OPACHoldsHistory preferences");
+}
diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
index 0e9f488055..cdaa32045c 100644
--- a/installer/data/mysql/mandatory/sysprefs.sql
+++ b/installer/data/mysql/mandatory/sysprefs.sql
@@ -400,6 +400,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('OpacHiddenItemsExceptions','',NULL,'List of borrower categories, separated by |, that can see items otherwise hidden by OpacHiddenItems','Textarea'),
 ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in OPAC','YesNo'),
 ('OPACHoldingsDefaultSortField','first_column','first_column|homebranch|holdingbranch','Default sort field for the holdings table at the OPAC','choice'),
+('OPACHoldsHistory','0','','If ON, enables display of Patron Holds History in OPAC','YesNo'),
 ('OPACHoldsIfAvailableAtPickup','1','','Allow to pickup up holds at libraries where the item is available','YesNo'),
 ('OPACHoldsIfAvailableAtPickupExceptions','','','List the patron categories not affected by OPACHoldsIfAvailableAtPickup if off','Free'),
 ('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 3d8cd4fab9..7ed9dab7b7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -697,6 +697,12 @@ OPAC:
                   yes: Allow
                   no: "Don't allow"
             - patrons to see what books they have checked out in the past.
+        -
+            - pref: OPACHoldsHistory
+              choices:
+                  yes: Allow
+                  no: "Don't allow"
+            - patrons to see what books they have place holds in the past.
         -
             - pref: EnableOpacSearchHistory
               default: 0
-- 
2.25.0