From cd294ea4dafec824d172adbbefc1f5c2520e4684 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 23 Oct 2020 18:14:34 +0000 Subject: [PATCH] Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind Signed-off-by: Katrin Fischer --- .../bootstrap/en/modules/opac-results-grouped.tt | 13 ++++++------- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 17 ++++++++--------- .../bootstrap/en/modules/opac-search-history.tt | 5 ++--- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 19 +++++++++---------- .../bootstrap/en/modules/opac-suggestions.tt | 17 ++++++++--------- .../lib/jquery/plugins/jquery.checkboxes.min.js | 13 ------------- 6 files changed, 33 insertions(+), 51 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.checkboxes.min.js diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt index afe486811d..c976070934 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt @@ -290,7 +290,6 @@ [% INCLUDE 'opac-bottom.inc' %] [% BLOCK jsinclude %] - [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]