From 93d3845c4958b1f2aa3905c089ab1c6bfa36549b Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 3 Sep 2020 12:06:51 +0000 Subject: [PATCH] Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t Signed-off-by: David Nind --- t/db_dependent/HoldsQueue.t | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t index 06047c647f..8c265f16b0 100755 --- a/t/db_dependent/HoldsQueue.t +++ b/t/db_dependent/HoldsQueue.t @@ -1413,7 +1413,8 @@ subtest 'Excludes from local holds priority' => sub { branchcode => $other_patron->branchcode, borrowernumber => $other_patron->borrowernumber, biblionumber => $item1->biblionumber, - priority => 1 + priority => 1, + itemtype => $item1->effective_itemtype } ); @@ -1422,7 +1423,8 @@ subtest 'Excludes from local holds priority' => sub { branchcode => $local_patron_excluded->branchcode, borrowernumber => $local_patron_excluded->borrowernumber, biblionumber => $item1->biblionumber, - priority => 2 + priority => 2, + itemtype => $item1->effective_itemtype } ); @@ -1431,7 +1433,8 @@ subtest 'Excludes from local holds priority' => sub { branchcode => $local_patron_not_excluded->branchcode, borrowernumber => $local_patron_not_excluded->borrowernumber, biblionumber => $item1->biblionumber, - priority => 3 + priority => 3, + itemtype => $item1->effective_itemtype } ); -- 2.11.0