From 60ac37b12d2b47760a240b2c077cc97542d89e4b Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Wed, 11 Nov 2020 13:19:18 +0000 Subject: [PATCH] Bug 24083: (follow-up) Make requested changes This commit makes the changes requested in comment #120 --- koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 -- misc/cronjobs/automatic_renewals.pl | 1 + opac/sco/sco-main.pl | 5 ++--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt index f2115e9f7a..907f4bdf81 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -133,7 +133,6 @@ - @@ -143,7 +142,6 @@ - diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl index 7c19e94b45..39f241248c 100755 --- a/misc/cronjobs/automatic_renewals.pl +++ b/misc/cronjobs/automatic_renewals.pl @@ -103,6 +103,7 @@ while ( my $auto_renew = $auto_renews->next ) { or $error eq 'on_reserve' or $error eq 'restriction' or $error eq 'overdue' + or $error eq 'too_unseen' or $error eq 'auto_account_expired' or $error eq 'auto_too_late' or $error eq 'auto_too_much_oweing' diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl index fa72f8496c..742f7f43ca 100755 --- a/opac/sco/sco-main.pl +++ b/opac/sco/sco-main.pl @@ -99,14 +99,13 @@ if (defined C4::Context->preference('SCOAllowCheckin')) { } my $issuerid = $loggedinuser; -my ($op, $patronid, $patronlogin, $patronpw, $barcode, $confirmed, $seen, $newissues) = ( +my ($op, $patronid, $patronlogin, $patronpw, $barcode, $confirmed, $newissues) = ( $query->param("op") || '', $query->param("patronid") || '', $query->param("patronlogin")|| '', $query->param("patronpw") || '', $query->param("barcode") || '', $query->param("confirmed") || '', - $query->param("seen") || 0, $query->param("newissues") || '', ); @@ -269,7 +268,7 @@ if ( $patron && ( $op eq 'renew' ) ) { my ($status,$renewerror) = CanBookBeRenewed( $borrower->{borrowernumber}, $item->itemnumber ); if ($status) { #warn "renewing"; - AddRenewal( $borrower->{borrowernumber}, $item->itemnumber, undef, undef, undef, undef, $seen ); + AddRenewal( $borrower->{borrowernumber}, $item->itemnumber, undef, undef, undef, undef, 1 ); push @newissueslist, $barcode; $template->param( renewed => 1 ); } -- 2.20.1