Bugzilla – Attachment 113604 Details for
Bug 27017
Add further defensive coding to EDI Invoice handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch adding log entries
0001-Bug-27017-Add-further-trace-logging-to-Invoice-handl.patch (text/plain), 1.42 KB, created by
Colin Campbell
on 2020-11-13 13:54:28 UTC
(
hide
)
Description:
Patch adding log entries
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2020-11-13 13:54:28 UTC
Size:
1.42 KB
patch
obsolete
>From b30774b50139a40761165859476b435e42717fd7 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 13 Nov 2020 13:46:13 +0000 >Subject: [PATCH] Bug 27017 Add further trace logging to Invoice handling > >Add two more logtrace entries to show what bibs the invoice >is receipting and log if for any reason there is no >ordernumber match. >--- > Koha/EDI.pm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/Koha/EDI.pm b/Koha/EDI.pm >index 445998d51e..35ef5dedb3 100644 >--- a/Koha/EDI.pm >+++ b/Koha/EDI.pm >@@ -293,10 +293,20 @@ sub process_invoice { > > foreach my $line ( @{$lines} ) { > my $ordernumber = $line->ordernumber; >+ if (!$ordernumber ) { >+ $logger->trace( "Skipping invoice line no associated ordernumber" ); >+ next; >+ } >+ > $logger->trace( "Receipting order:$ordernumber Qty: ", > $line->quantity ); > > my $order = $schema->resultset('Aqorder')->find($ordernumber); >+ if ($order->biblionumber->biblionumber) { >+ my $b = $order->biblionumber->biblionumber; >+ my $id = $line->item_number_id; >+ $logger->trace("Updating bib:$b id:$id"); >+ } > > # ModReceiveOrder does not validate that $ordernumber exists validate here > if ($order) { >-- >2.28.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27017
:
113604
|
142714
|
142726
|
142730