From a20b7dfe77895dc09eb3bc3748a16c65e52d80f3 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 10 Nov 2020 12:55:17 +0100 Subject: [PATCH] Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Sally Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt index 84db9c25fb..227daf7137 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ -117,7 +117,7 @@ [% ELSE %] [% END %] - Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during self-registration.) + Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during self-registration if PatronSelfRegistrationVerifyByEmail if set.)
  • [% IF attribute_type AND attribute_type.staff_searchable %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 60eaa58379..6736294268 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -936,7 +936,7 @@ [% END %] - [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && action != 'new' ) %] + [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && ! ( action == 'new' && Koha.Preference('PatronSelfRegistrationVerifyByEmail') ) ) %]
    [% FOREACH pa_class IN patron_attribute_classes %] -- 2.20.1