Bugzilla – Attachment 113769 Details for
Bug 18595
Move C4::Members::Messaging to Koha namespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18595: (follow-up) Remove duplicated logic
Bug-18595-follow-up-Remove-duplicated-logic.patch (text/plain), 1.25 KB, created by
Lari Taskula
on 2020-11-18 04:30:06 UTC
(
hide
)
Description:
Bug 18595: (follow-up) Remove duplicated logic
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2020-11-18 04:30:06 UTC
Size:
1.25 KB
patch
obsolete
>From 27fb80757c39b4837a1adc5c86286d58b645c8af Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Wed, 18 Nov 2020 04:25:57 +0000 >Subject: [PATCH] Bug 18595: (follow-up) Remove duplicated logic > >Sponsored-by: The National Library of Finland >--- > C4/Reserves.pm | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 718d3c0217..50ee7271ec 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1854,12 +1854,7 @@ sub _koha_notify_reserve { > my $transports = $messagingpref->message_transport_types if $messagingpref; > foreach my $mtt (keys %{$transports}) { > my $letter_code = $transports->{$mtt}; >- next if ( >- ( $mtt eq 'email' and not $to_address ) # No email address >- or ( $mtt eq 'sms' and not $patron->smsalertnumber ) # No SMS number >- or ( $mtt eq 'itiva' and C4::Context->preference('TalkingTechItivaPhoneNotification') ) # Notice is handled by TalkingTech_itiva_outbound.pl >- or ( $mtt eq 'phone' and not $patron->phone ) # No phone number to call >- ); >+ next unless $messagingpref->mtt_deliverable($mtt); > > &$send_notification($mtt, $letter_code); > $notification_sent++; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18595
:
63435
|
63436
|
63437
|
63438
|
63439
|
63440
|
63441
|
63794
|
63795
|
63796
|
63797
|
63798
|
63799
|
63800
|
63813
|
63815
|
63816
|
63817
|
63818
|
63819
|
63820
|
63821
|
63822
|
63823
|
63824
|
63825
|
63826
|
63827
|
63828
|
63829
|
69441
|
69442
|
69443
|
69444
|
69445
|
69446
|
69447
|
69448
|
69449
|
69450
|
69451
|
69452
|
69453
|
69667
|
69668
|
69669
|
69670
|
69671
|
69672
|
69673
|
69674
|
93873
|
93874
|
93875
|
93876
|
93877
|
93878
|
93879
|
93880
|
93908
|
94753
|
94754
|
103444
|
103445
|
103446
|
103447
|
103448
|
103449
|
103450
|
103451
|
103452
|
110151
|
110152
|
110153
|
110154
|
110155
|
110156
|
110157
|
110158
|
110159
|
112147
|
112148
|
112149
|
112150
|
112151
|
112152
|
112153
|
112154
|
112155
|
112690
|
113126
|
113192
|
113221
|
113222
|
113769
|
146541
|
146542
|
146543
|
146544
|
146545
|
146546
|
146547
|
146548
|
146549
|
146550
|
146551
|
146552