View | Details | Raw Unified | Return to bug 22690
Collapse All | Expand All

(-)a/C4/Items.pm (-52 / +1 lines)
Lines 39-45 BEGIN { Link Here
39
        GetHostItemsInfo
39
        GetHostItemsInfo
40
        get_hostitemnumbers_of
40
        get_hostitemnumbers_of
41
        GetHiddenItemnumbers
41
        GetHiddenItemnumbers
42
        MoveItemFromBiblio
43
        CartToShelf
42
        CartToShelf
44
        GetAnalyticsCount
43
        GetAnalyticsCount
45
        SearchItems
44
        SearchItems
Lines 66-71 use Koha::AuthorisedValues; Link Here
66
use Koha::DateUtils qw(dt_from_string);
65
use Koha::DateUtils qw(dt_from_string);
67
use Koha::Database;
66
use Koha::Database;
68
67
68
use Koha::Biblios;
69
use Koha::Biblioitems;
69
use Koha::Biblioitems;
70
use Koha::Items;
70
use Koha::Items;
71
use Koha::ItemTypes;
71
use Koha::ItemTypes;
Lines 1086-1142 the inner workings of C<C4::Items>. Link Here
1086
1086
1087
=cut
1087
=cut
1088
1088
1089
=head2 MoveItemFromBiblio
1090
1091
  MoveItemFromBiblio($itenumber, $frombiblio, $tobiblio);
1092
1093
Moves an item from a biblio to another
1094
1095
Returns undef if the move failed or the biblionumber of the destination record otherwise
1096
1097
=cut
1098
1099
sub MoveItemFromBiblio {
1100
    my ($itemnumber, $frombiblio, $tobiblio) = @_;
1101
    my $dbh = C4::Context->dbh;
1102
    my ( $tobiblioitem ) = $dbh->selectrow_array(q|
1103
        SELECT biblioitemnumber
1104
        FROM biblioitems
1105
        WHERE biblionumber = ?
1106
    |, undef, $tobiblio );
1107
    my $return = $dbh->do(q|
1108
        UPDATE items
1109
        SET biblioitemnumber = ?,
1110
            biblionumber = ?
1111
        WHERE itemnumber = ?
1112
            AND biblionumber = ?
1113
    |, undef, $tobiblioitem, $tobiblio, $itemnumber, $frombiblio );
1114
    if ($return == 1) {
1115
        my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
1116
        $indexer->index_records( $tobiblio, "specialUpdate", "biblioserver" );
1117
        $indexer->index_records( $frombiblio, "specialUpdate", "biblioserver" );
1118
	    # Checking if the item we want to move is in an order 
1119
        require C4::Acquisition;
1120
        my $order = C4::Acquisition::GetOrderFromItemnumber($itemnumber);
1121
	    if ($order) {
1122
		    # Replacing the biblionumber within the order if necessary
1123
		    $order->{'biblionumber'} = $tobiblio;
1124
	        C4::Acquisition::ModOrder($order);
1125
	    }
1126
1127
        # Update reserves, hold_fill_targets, tmp_holdsqueue and linktracker tables
1128
        for my $table_name ( qw( reserves hold_fill_targets tmp_holdsqueue linktracker ) ) {
1129
            $dbh->do( qq|
1130
                UPDATE $table_name
1131
                SET biblionumber = ?
1132
                WHERE itemnumber = ?
1133
            |, undef, $tobiblio, $itemnumber );
1134
        }
1135
        return $tobiblio;
1136
	}
1137
    return;
1138
}
1139
1140
=head2 _marc_from_item_hash
1089
=head2 _marc_from_item_hash
1141
1090
1142
  my $item_marc = _marc_from_item_hash($item, $frameworkcode[, $unlinked_item_subfields]);
1091
  my $item_marc = _marc_from_item_hash($item, $frameworkcode[, $unlinked_item_subfields]);
(-)a/Koha/Biblio.pm (+24 lines)
Lines 41-46 use Koha::CirculationRules; Link Here
41
use Koha::Item::Transfer::Limits;
41
use Koha::Item::Transfer::Limits;
42
use Koha::Items;
42
use Koha::Items;
43
use Koha::Libraries;
43
use Koha::Libraries;
44
use Koha::SearchEngine::Indexer;
44
use Koha::Suggestions;
45
use Koha::Suggestions;
45
use Koha::Subscriptions;
46
use Koha::Subscriptions;
46
47
Lines 831-836 sub to_api_mapping { Link Here
831
    };
832
    };
832
}
833
}
833
834
835
=head3 adopt_items_from_biblio
836
837
$biblio->adopt_items_from_biblio($from_biblio);
838
839
Move items from the given biblio to this one.
840
841
=cut
842
843
sub adopt_items_from_biblio {
844
    my ( $self, $from_biblio ) = @_;
845
846
    my $items = $from_biblio->items;
847
    if ($items) {
848
        while (my $item = $items->next()) {
849
            $item->move_to_biblio($self, { skip_record_index => 1 });
850
        }
851
        my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
852
        $indexer->index_records( $self->biblionumber, "specialUpdate", "biblioserver" );
853
        $indexer->index_records( $from_biblio->biblionumber, "specialUpdate", "biblioserver" );
854
    }
855
}
856
857
834
=head2 Internal methods
858
=head2 Internal methods
835
859
836
=head3 type
860
=head3 type
(-)a/Koha/Item.pm (+80 lines)
Lines 1053-1058 sub itemtype { Link Here
1053
    return Koha::ItemTypes->find( $self->effective_itemtype );
1053
    return Koha::ItemTypes->find( $self->effective_itemtype );
1054
}
1054
}
1055
1055
1056
=head3 item_orders
1057
1058
my $orders = $item->item_orders();
1059
1060
Returns a Koha::Acquisition::Orders object
1061
1062
=cut
1063
1064
sub item_orders {
1065
    my ( $self ) = @_;
1066
1067
    my $orders = $self->_result->item_orders;
1068
    return Koha::Acquisition::Orders->_new_from_dbic($orders);
1069
}
1070
1071
=head3 move_to_biblio
1072
1073
  $item->move_to_biblio($to_biblio[, $params]);
1074
1075
Move the item to another biblio and update any references also in other tables.
1076
1077
The final optional parameter, C<$params>, is expected to contain the
1078
'skip_record_index' key, which is relayed down to Koha::Item->store.
1079
There it prevents calling index_records, which takes most of the
1080
time in batch adds/deletes. The caller must take care of calling
1081
index_records separately.
1082
1083
$params:
1084
    skip_record_index => 1|0
1085
1086
Returns undef if the move failed or the biblionumber of the destination record otherwise
1087
1088
=cut
1089
1090
sub move_to_biblio {
1091
    my ( $self, $to_biblio, $params ) = @_;
1092
1093
    $params //= {};
1094
1095
    return unless $self->biblionumber != $to_biblio->biblionumber;
1096
1097
    my $biblionumber = $to_biblio->biblionumber;
1098
1099
    # Own biblionumber and biblioitemnumber
1100
    $self->set({
1101
        biblionumber => $biblionumber,
1102
        biblioitemnumber => $to_biblio->biblioitem->biblioitemnumber
1103
    })->store({ skip_record_index => $params->{skip_record_index} });
1104
1105
    # Acquisition orders
1106
    $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
1107
1108
    # Holds
1109
    $self->holds->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
1110
1111
    # hold_fill_target (there's no Koha object available)
1112
    my $hold_fill_target = $self->_result->hold_fill_target;
1113
    if ($hold_fill_target) {
1114
        $hold_fill_target->update({ biblionumber => $biblionumber });
1115
    }
1116
1117
    # tmp_holdsqueues - Can't update with DBIx since the table is missing a primary key
1118
    # and can't even fake one since the significant columns are nullable.
1119
    my $storage = $self->_result->result_source->storage;
1120
    $storage->dbh_do(
1121
        sub {
1122
            my ($storage, $dbh, @cols) = @_;
1123
1124
            $dbh->do("UPDATE tmp_holdsqueue SET biblionumber=? WHERE itemnumber=?", undef, $biblionumber, $self->itemnumber);
1125
        }
1126
    );
1127
1128
    # linktrackers
1129
    my $schema = Koha::Database->new()->schema();
1130
    my $linktrackers = $schema->resultset('Linktracker')->search({ itemnumber => $self->itemnumber });
1131
    $linktrackers->update_all({ biblionumber => $biblionumber });
1132
1133
    return $biblionumber;
1134
}
1135
1056
=head2 Internal methods
1136
=head2 Internal methods
1057
1137
1058
=head3 _after_item_action_hooks
1138
=head3 _after_item_action_hooks
(-)a/Koha/Schema/Result/Item.pm (+13 lines)
Lines 778-783 __PACKAGE__->add_columns( Link Here
778
    '+exclude_from_local_holds_priority' => { is_boolean => 1 },
778
    '+exclude_from_local_holds_priority' => { is_boolean => 1 },
779
);
779
);
780
780
781
# Relationship with orders via the aqorders_item table that not have foreign keys
782
__PACKAGE__->has_many(
783
  "aqorders_item",
784
  "Koha::Schema::Result::AqordersItem",
785
  { "foreign.itemnumber" => "self.itemnumber" },
786
  { cascade_copy => 0, cascade_delete => 0 },
787
);
788
__PACKAGE__->many_to_many(
789
  "item_orders",
790
  "aqorders_item",
791
  "ordernumber",
792
);
793
781
use C4::Context;
794
use C4::Context;
782
sub effective_itemtype {
795
sub effective_itemtype {
783
    my ( $self ) = @_;
796
    my ( $self ) = @_;
(-)a/cataloguing/merge.pl (-15 / +7 lines)
Lines 31-36 use C4::Reserves qw/MergeHolds/; Link Here
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
32
32
33
use Koha::BiblioFrameworks;
33
use Koha::BiblioFrameworks;
34
use Koha::Biblios;
34
use Koha::Items;
35
use Koha::Items;
35
use Koha::MetadataRecord;
36
use Koha::MetadataRecord;
36
37
Lines 80-104 if ($merge) { Link Here
80
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
81
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
81
82
82
    my $frameworkcode = $input->param('frameworkcode');
83
    my $frameworkcode = $input->param('frameworkcode');
83
    my @notmoveditems;
84
84
85
    # Modifying the reference record
85
    # Modifying the reference record
86
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
86
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
87
87
88
    # Moving items from the other record to the reference record
88
    # Moving items and article requests from the other record to the reference record
89
    my $biblio = Koha::Biblios->find($ref_biblionumber);
89
    foreach my $biblionumber (@biblionumbers) {
90
    foreach my $biblionumber (@biblionumbers) {
90
        my $items = Koha::Items->search({ biblionumber => $biblionumber });
91
        my $from_biblio = Koha::Biblios->find($biblionumber);
91
        while ( my $item = $items->next) {
92
        $biblio->adopt_items_from_biblio($from_biblio);
92
            my $res = MoveItemFromBiblio( $item->itemnumber, $biblionumber, $ref_biblionumber );
93
        $from_biblio->article_requests->update({ biblionumber => $ref_biblionumber }, { no_triggers => 1 });
93
            if ( not defined $res ) {
94
                push @notmoveditems, $item->itemnumber;
95
            }
96
        }
97
    }
98
    # If some items could not be moved :
99
    if (scalar(@notmoveditems) > 0) {
100
        my $itemlist = join(' ',@notmoveditems);
101
        push @errors, { code => "CANNOT_MOVE", value => $itemlist };
102
    }
94
    }
103
95
104
    my $sth_subscription = $dbh->prepare("
96
    my $sth_subscription = $dbh->prepare("
Lines 162-168 if ($merge) { Link Here
162
    # Moving suggestions
154
    # Moving suggestions
163
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
155
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
164
156
165
    # Moving orders (orders linked to items of frombiblio have already been moved by MoveItemFromBiblio)
157
    # Moving orders (orders linked to items of frombiblio have already been moved by adopt_items_from_biblio)
166
    my @allorders = GetOrdersByBiblionumber($biblionumber);
158
    my @allorders = GetOrdersByBiblionumber($biblionumber);
167
    foreach my $myorder (@allorders) {
159
    foreach my $myorder (@allorders) {
168
        $myorder->{'biblionumber'} = $ref_biblionumber;
160
        $myorder->{'biblionumber'} = $ref_biblionumber;
(-)a/cataloguing/moveitem.pl (-1 / +2 lines)
Lines 73-80 if ( $barcode && $biblionumber ) { Link Here
73
73
74
        $itemnumber = $item->itemnumber;
74
        $itemnumber = $item->itemnumber;
75
        my $frombiblionumber = $item->biblionumber;
75
        my $frombiblionumber = $item->biblionumber;
76
        my $to_biblio = Koha::Biblios->find($biblionumber);
76
77
77
        my $moveresult = MoveItemFromBiblio( $itemnumber, $frombiblionumber, $biblionumber );
78
        my $moveresult = $item->move_to_biblio($to_biblio);
78
        if ($moveresult) {
79
        if ($moveresult) {
79
            $template->param(
80
            $template->param(
80
                success => 1,
81
                success => 1,
(-)a/t/db_dependent/Items/MoveItemFromBiblio.t (-85 lines)
Lines 1-85 Link Here
1
#!/usr/bin/perl
2
#
3
# This file is part of Koha.
4
#
5
# Koha is free software; you can redistribute it and/or modify it
6
# under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 3 of the License, or
8
# (at your option) any later version.
9
#
10
# Koha is distributed in the hope that it will be useful, but
11
# WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
18
use Modern::Perl;
19
use Test::More tests => 8;
20
21
use C4::Items;
22
use C4::Reserves;
23
use Koha::Database;
24
use Koha::Holds;
25
use Koha::Items;
26
27
use t::lib::TestBuilder;
28
use Data::Dumper qw|Dumper|;
29
30
my $schema  = Koha::Database->new->schema;
31
$schema->storage->txn_begin;
32
my $builder = t::lib::TestBuilder->new;
33
34
my $from_biblio = $builder->build_sample_biblio;
35
my $to_biblio = $builder->build_sample_biblio;
36
37
my $item1 = $builder->build_sample_item(
38
    { biblionumber => $from_biblio->biblionumber, } );
39
my $item2 = $builder->build_sample_item(
40
    { biblionumber => $from_biblio->biblionumber, } );
41
my $item3 = $builder->build_sample_item(
42
    { biblionumber => $to_biblio->biblionumber, } );
43
44
45
my $bib_level_hold_not_to_move = $builder->build(
46
    {   source => 'Reserve',
47
        value  => { biblionumber => $from_biblio->biblionumber, },
48
    }
49
);
50
my $item_level_hold_not_to_move = $builder->build(
51
    {   source => 'Reserve',
52
        value  => { biblionumber => $from_biblio->biblionumber, itemnumber => $item1->itemnumber },
53
    }
54
);
55
my $item_level_hold_to_move = $builder->build(
56
    {   source => 'Reserve',
57
        value  => { biblionumber => $from_biblio->biblionumber, itemnumber => $item2->itemnumber },
58
    }
59
);
60
61
my $to_biblionumber_after_moved = C4::Items::MoveItemFromBiblio( $item2->itemnumber, $from_biblio->biblionumber, $to_biblio->biblionumber );
62
63
is( $to_biblionumber_after_moved, $to_biblio->biblionumber, 'MoveItemFromBiblio should return the to_biblionumber if success' );
64
65
$to_biblionumber_after_moved = C4::Items::MoveItemFromBiblio( $item2->itemnumber, $from_biblio->biblionumber, $to_biblio->biblionumber );
66
67
is( $to_biblionumber_after_moved, undef, 'MoveItemFromBiblio should return undef if the move has failed. If called twice, the item is not attached to the first biblio anymore' );
68
69
my $get_item1 = Koha::Items->find( $item1->itemnumber );
70
is( $get_item1->biblionumber, $from_biblio->biblionumber, 'The item1 should not have been moved' );
71
my $get_item2 = Koha::Items->find( $item2->itemnumber );
72
is( $get_item2->biblionumber, $to_biblio->biblionumber, 'The item2 should have been moved' );
73
my $get_item3 = Koha::Items->find( $item3->itemnumber );
74
is( $get_item3->biblionumber, $to_biblio->biblionumber, 'The item3 should not have been moved' );
75
76
my $get_bib_level_hold    = Koha::Holds->find( $bib_level_hold_not_to_move->{reserve_id} );
77
my $get_item_level_hold_1 = Koha::Holds->find( $item_level_hold_not_to_move->{reserve_id} );
78
my $get_item_level_hold_2 = Koha::Holds->find( $item_level_hold_to_move->{reserve_id} );
79
80
is( $get_bib_level_hold->biblionumber,    $from_biblio->biblionumber, 'MoveItemFromBiblio should not have moved the biblio-level hold' );
81
is( $get_item_level_hold_1->biblionumber, $from_biblio->biblionumber, 'MoveItemFromBiblio should not have moved the item-level hold placed on item 1' );
82
is( $get_item_level_hold_2->biblionumber, $to_biblio->biblionumber,   'MoveItemFromBiblio should have moved the item-level hold placed on item 2' );
83
84
$schema->storage->txn_rollback;
85
(-)a/t/db_dependent/Koha/Item.t (-1 / +180 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 7;
22
use Test::More tests => 8;
23
23
24
use C4::Biblio;
24
use C4::Biblio;
25
use C4::Circulation;
25
use C4::Circulation;
Lines 628-630 subtest 'Tests for itemtype' => sub { Link Here
628
628
629
    $schema->storage->txn_rollback;
629
    $schema->storage->txn_rollback;
630
};
630
};
631
632
subtest 'move_to_biblio() tests' => sub {
633
634
    plan tests => 16;
635
636
    $schema->storage->txn_begin;
637
638
    my $dbh = C4::Context->dbh;
639
640
    my $source_biblio = $builder->build_sample_biblio();
641
    my $target_biblio = $builder->build_sample_biblio();
642
643
    my $source_biblionumber = $source_biblio->biblionumber;
644
    my $target_biblionumber = $target_biblio->biblionumber;
645
646
    my $item1 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
647
    my $item2 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
648
    my $item3 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
649
650
    my $itemnumber1 = $item1->itemnumber;
651
    my $itemnumber2 = $item2->itemnumber;
652
653
    my $library = $builder->build_object({ class => 'Koha::Libraries' });
654
655
    my $patron = $builder->build_object({
656
        class => 'Koha::Patrons',
657
        value => { branchcode => $library->branchcode }
658
    });
659
    my $borrowernumber = $patron->borrowernumber;
660
661
    my $aq_budget = $builder->build({
662
        source => 'Aqbudget',
663
        value  => {
664
            budget_notes => 'test',
665
        },
666
    });
667
668
    my $aq_order1 = $builder->build_object({
669
        class => 'Koha::Acquisition::Orders',
670
        value  => {
671
            biblionumber => $source_biblionumber,
672
            budget_id => $aq_budget->{budget_id},
673
        },
674
    });
675
    my $aq_order_item1 = $builder->build({
676
        source => 'AqordersItem',
677
        value  => {
678
            ordernumber => $aq_order1->ordernumber,
679
            itemnumber => $itemnumber1,
680
        },
681
    });
682
    my $aq_order2 = $builder->build_object({
683
        class => 'Koha::Acquisition::Orders',
684
        value  => {
685
            biblionumber => $source_biblionumber,
686
            budget_id => $aq_budget->{budget_id},
687
        },
688
    });
689
    my $aq_order_item2 = $builder->build({
690
        source => 'AqordersItem',
691
        value  => {
692
            ordernumber => $aq_order2->ordernumber,
693
            itemnumber => $itemnumber2,
694
        },
695
    });
696
697
    my $bib_level_hold = $builder->build_object({
698
        class => 'Koha::Holds',
699
        value  => {
700
            biblionumber => $source_biblionumber,
701
        },
702
    });
703
    my $item_level_hold1 = $builder->build_object({
704
        class => 'Koha::Holds',
705
        value  => {
706
            biblionumber => $source_biblionumber,
707
            itemnumber => $itemnumber1,
708
        },
709
    });
710
    my $item_level_hold2 = $builder->build_object({
711
        class => 'Koha::Holds',
712
        value  => {
713
            biblionumber => $source_biblionumber,
714
            itemnumber => $itemnumber2,
715
        }
716
    });
717
718
    my $tmp_holdsqueue1 = $builder->build({
719
        source => 'TmpHoldsqueue',
720
        value  => {
721
            borrowernumber => $borrowernumber,
722
            biblionumber   => $source_biblionumber,
723
            itemnumber     => $itemnumber1,
724
        }
725
    });
726
    my $tmp_holdsqueue2 = $builder->build({
727
        source => 'TmpHoldsqueue',
728
        value  => {
729
            borrowernumber => $borrowernumber,
730
            biblionumber   => $source_biblionumber,
731
            itemnumber     => $itemnumber2,
732
        }
733
    });
734
    my $hold_fill_target1 = $builder->build({
735
        source => 'HoldFillTarget',
736
        value  => {
737
            borrowernumber     => $borrowernumber,
738
            biblionumber       => $source_biblionumber,
739
            itemnumber         => $itemnumber1,
740
        }
741
    });
742
    my $hold_fill_target2 = $builder->build({
743
        source => 'HoldFillTarget',
744
        value  => {
745
            borrowernumber     => $borrowernumber,
746
            biblionumber       => $source_biblionumber,
747
            itemnumber         => $itemnumber2,
748
        }
749
    });
750
    my $linktracker1 = $builder->build({
751
        source => 'Linktracker',
752
        value  => {
753
            borrowernumber     => $borrowernumber,
754
            biblionumber       => $source_biblionumber,
755
            itemnumber         => $itemnumber1,
756
        }
757
    });
758
    my $linktracker2 = $builder->build({
759
        source => 'Linktracker',
760
        value  => {
761
            borrowernumber     => $borrowernumber,
762
            biblionumber       => $source_biblionumber,
763
            itemnumber         => $itemnumber2,
764
        }
765
    });
766
767
    my $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
768
    is($to_biblionumber_after_move, $target_biblionumber, 'move_to_biblio returns the target biblionumber if success');
769
770
    $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
771
    is($to_biblionumber_after_move, undef, 'move_to_biblio returns undef if the move has failed. If called twice, the item is not attached to the first biblio anymore');
772
773
    my $get_item1 = Koha::Items->find( $item1->itemnumber );
774
    is($get_item1->biblionumber, $target_biblionumber, 'item1 is moved');
775
    my $get_item2 = Koha::Items->find( $item2->itemnumber );
776
    is($get_item2->biblionumber, $source_biblionumber, 'item2 is not moved');
777
    my $get_item3 = Koha::Items->find( $item3->itemnumber );
778
    is($get_item3->biblionumber, $source_biblionumber, 'item3 is not moved');
779
780
    $aq_order1->discard_changes;
781
    $aq_order2->discard_changes;
782
    is($aq_order1->biblionumber, $target_biblionumber, 'move_to_biblio moves aq_orders for item 1');
783
    is($aq_order2->biblionumber, $source_biblionumber, 'move_to_biblio does not move aq_orders for item 2');
784
785
    $bib_level_hold->discard_changes;
786
    $item_level_hold1->discard_changes;
787
    $item_level_hold2->discard_changes;
788
    is($bib_level_hold->biblionumber,   $source_biblionumber, 'move_to_biblio does not move the biblio-level hold');
789
    is($item_level_hold1->biblionumber, $target_biblionumber, 'move_to_biblio moves the item-level hold placed on item 1');
790
    is($item_level_hold2->biblionumber, $source_biblionumber, 'move_to_biblio does not move the item-level hold placed on item 2');
791
792
    my $get_tmp_holdsqueue1 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue1->{itemnumber} })->single;
793
    my $get_tmp_holdsqueue2 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue2->{itemnumber} })->single;
794
    is($get_tmp_holdsqueue1->biblionumber, $target_biblionumber, 'move_to_biblio moves tmp_holdsqueue for item 1');
795
    is($get_tmp_holdsqueue2->biblionumber, $source_biblionumber, 'move_to_biblio does not move tmp_holdsqueue for item 2');
796
797
    my $get_hold_fill_target1 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target1->{itemnumber} })->single;
798
    my $get_hold_fill_target2 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target2->{itemnumber} })->single;
799
    # Why does ->biblionumber return a Biblio object???
800
    is($get_hold_fill_target1->biblionumber->biblionumber, $target_biblionumber, 'move_to_biblio moves hold_fill_targets for item 1');
801
    is($get_hold_fill_target2->biblionumber->biblionumber, $source_biblionumber, 'move_to_biblio does not move hold_fill_targets for item 2');
802
803
    my $get_linktracker1 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker1->{itemnumber} })->single;
804
    my $get_linktracker2 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker2->{itemnumber} })->single;
805
    is($get_linktracker1->biblionumber, $target_biblionumber, 'move_to_biblio moves linktracker for item 1');
806
    is($get_linktracker2->biblionumber, $source_biblionumber, 'move_to_biblio does not move linktracker for item 2');
807
808
    $schema->storage->txn_rollback;
809
};
(-)a/t/db_dependent/Koha/SearchEngine/Indexer.t (-2 / +10 lines)
Lines 60-66 subtest 'Test indexer object creation' => sub { Link Here
60
};
60
};
61
61
62
subtest 'Test indexer calls' => sub {
62
subtest 'Test indexer calls' => sub {
63
    plan tests => 40;
63
    plan tests => 44;
64
64
65
    my @engines = ('Zebra');
65
    my @engines = ('Zebra');
66
    eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; };
66
    eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; };
Lines 158-163 subtest 'Test indexer calls' => sub { Link Here
158
            AddReturn($item->barcode, $item->homebranch, 0, undef);
158
            AddReturn($item->barcode, $item->homebranch, 0, undef);
159
        } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued";
159
        } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued";
160
160
161
        my $item3 = $builder->build_sample_item({biblionumber => $biblio->biblionumber});
162
        my $item4 = $builder->build_sample_item({biblionumber => $biblio->biblionumber});
163
        warnings_are{
164
            $item3->move_to_biblio($biblio2);
165
        } [$engine,"Koha::Item"], "index_records is called for $engine when moving an item to another biblio (Item->move_to_biblio)";
166
        warnings_are{
167
            $item4->move_to_biblio($biblio2, { skip_record_index => 1 });
168
        } undef, "index_records is not called for $engine when moving an item to another biblio (Item->move_to_biblio) if skip_record_index passed";
169
161
        $builder->build({
170
        $builder->build({
162
            source => 'Branchtransfer',
171
            source => 'Branchtransfer',
163
            value => {
172
            value => {
164
- 

Return to bug 22690