From 5f32e6de90b9e17c311acf15c2f05bc6ba7f5ef0 Mon Sep 17 00:00:00 2001 From: Blou Date: Tue, 24 Nov 2020 17:03:32 -0500 Subject: [PATCH] Bug 27082: uncertainprice.pl does not handle pagination To reproduce: 1- create a basket 2- add more of 20 orders with uncertain price 3- click on uncertain price button 4- on page 1 of list, uncheck uncertain box of an order 5- click on save button 6- orders who were on page 2 are not display anymore in page uncertainprice.pl 7- return to basket view acqui/basket.pl 8- orders who were on page 2 have "rvcd" label and quantity is null The data in page 2 and beyond is not transmitted, but the code doesn't handle that. This patch makes sure that all that (empty) data is not (wrongly) processed. Sponsored by: CCSR Signed-off-by: Nick Clemens --- acqui/uncertainprice.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/acqui/uncertainprice.pl b/acqui/uncertainprice.pl index ac2964ebbe..82b98b2d3d 100755 --- a/acqui/uncertainprice.pl +++ b/acqui/uncertainprice.pl @@ -88,6 +88,7 @@ if ( $op eq 'validate' ) { for (my $i=0; $i < $count; $i++) { my $order = pop(@orders); my $ordernumber = $order->{ordernumber}; + next unless ($input->param('qty'.$ordernumber)); my $order_as_from_db=GetOrder($order->{ordernumber}); $order->{'listprice'} = $input->param('price'.$ordernumber); $order->{'ecost'}= $input->param('price'.$ordernumber) - (($input->param('price'.$ordernumber) /100) * $bookseller->discount); -- 2.11.0