Bugzilla – Attachment 114120 Details for
Bug 26976
When renewalsallowed is empty the UI is not correct
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26976: Display 0 if renewalsallowed is not defined
Bug-26976-Display-0-if-renewalsallowed-is-not-defi.patch (text/plain), 1.25 KB, created by
Victor Grousset/tuxayo
on 2020-12-02 21:36:57 UTC
(
hide
)
Description:
Bug 26976: Display 0 if renewalsallowed is not defined
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2020-12-02 21:36:57 UTC
Size:
1.25 KB
patch
obsolete
>From a1a265ef440e537aca86c9f40d3165f848d14e28 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 20 Nov 2020 11:27:45 +0100 >Subject: [PATCH] Bug 26976: Display 0 if renewalsallowed is not defined > >If the circulation rule "renewalsallowed" is not set (or an empty >string) then the checkout list displays >(0 of renewals remaining) >It should display "0 of 0" > >Test plan: >Set renewalsallowed to an empty string >Check an item out >Notice the change > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > svc/checkouts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/checkouts b/svc/checkouts >index f54567ff5f..38c0017e2c 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -247,7 +247,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { > onsite_checkout => $c->{onsite_checkout}, > enumchron => $c->{enumchron}, > renewals_count => $renewals_count, >- renewals_allowed => $renewals_allowed, >+ renewals_allowed => $renewals_allowed || 0, > renewals_remaining => $renewals_remaining, > unseen_count => $unseen_count, > unseen_allowed => $unseen_allowed, >-- >2.29.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26976
:
113869
|
113883
| 114120