From 183a619db87aba93d40ac7f41559ae885a9a8839 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 14 Jun 2012 12:40:08 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 7805 Followup for perlcritic messages Content-Type: text/plain; charset="utf-8" Signed-off-by: Owen Leonard Tested by going to Lists and doubleclicking a list to see its contents (in opac or staff). It works. No warnings in the log. I am ready to sign off. --- C4/VirtualShelves.pm | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm index 20f3620..25d092a 100644 --- a/C4/VirtualShelves.pm +++ b/C4/VirtualShelves.pm @@ -221,7 +221,7 @@ Returns the above-mentioned fields for passed virtual shelf number. =cut -sub GetShelf ($) { +sub GetShelf { my ($shelfnumber) = @_; my $query = qq( SELECT shelfnumber, shelfname, owner, category, sortfield, @@ -252,7 +252,7 @@ from C4::Circulation. =cut -sub GetShelfContents ($;$$$) { +sub GetShelfContents { my ($shelfnumber, $row_count, $offset, $sortfield) = @_; my $dbh=C4::Context->dbh(); my $sth1 = $dbh->prepare("SELECT count(*) FROM virtualshelfcontents WHERE shelfnumber = ?"); @@ -351,7 +351,7 @@ sub AddToShelf { my $sth = $dbh->prepare($query); $sth->execute( $shelfnumber, $biblionumber ); - ($sth->rows) and return undef; # already on shelf + ($sth->rows) and return; # already on shelf $query = qq( INSERT INTO virtualshelfcontents (shelfnumber, biblionumber, flags, borrowernumber) @@ -658,15 +658,6 @@ sub _biblionumber_sth { #only used in obsolete sub below $sth; } -sub each_biblionumbers (&$) { #OBSOLETE - my ($code,$shelf) = @_; - my $ref = _biblionumber_sth($shelf)->fetchall_arrayref; - map { - $_=$$_[0]; - $code->(); - } @$ref; -} - sub _CheckShelfName { my ($name, $cat, $owner, $number)= @_; -- 1.7.9.5