From 1721a7613f3b337bdcd55d15c8b3c911e73b02be Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 4 Dec 2020 08:21:36 -0300 Subject: [PATCH] Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D --- opac/opac-reserve.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index b0ed0886895..139d7101afb 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -71,6 +71,12 @@ for ( C4::Context->preference("OPACShowHoldQueueDetails") ) { } my $patron = Koha::Patrons->find( $borrowernumber ); +my $category = $patron->category; +# no OpacHiddenItems rules used if category is excepted +my $item_hide_rules = + ( $category->override_hidden_items ) + ? {} + : C4::Context->yaml_preference('OpacHiddenItems'); my $can_place_hold_if_available_at_pickup = C4::Context->preference('OPACHoldsIfAvailableAtPickup'); unless ( $can_place_hold_if_available_at_pickup ) { @@ -461,6 +467,12 @@ foreach my $biblioNum (@biblionumbers) { my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode }); my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs }; + my $visible_items = { map { $_->itemnumber => 1 } $biblio->items->filter_by_visible_in_opac( { rules => $item_hide_rules } ) }; + + # Only keep the items that are visible in the opac (i.e. those in %visible_items) + # FIXME: We should get rid of itemInfos altogether and use $visible_items + $biblioData->{itemInfos} = [ grep { $visible_items->{ $_->{itemnumber} } } @{ $biblioData->{itemInfos} } ]; + $biblioLoopIter{itemLoop} = []; my $numCopiesAvailable = 0; my $numCopiesOPACAvailable = 0; -- 2.29.2