Bugzilla – Attachment 114211 Details for
Bug 27058
Cannot place hold to ordered item when on shelf holds are not allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27058: Make checkout availability use all notforloan reasons
Bug-27058-Make-checkout-availability-use-all-notfo.patch (text/plain), 1.80 KB, created by
Kyle M Hall
on 2020-12-04 18:30:20 UTC
(
hide
)
Description:
Bug 27058: Make checkout availability use all notforloan reasons
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2020-12-04 18:30:20 UTC
Size:
1.80 KB
patch
obsolete
>From 09d6ee88ebe1e9dc9e6bfa79b33411ce5b992361 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Thu, 19 Nov 2020 16:55:18 +0200 >Subject: [PATCH] Bug 27058: Make checkout availability use all notforloan > reasons > >The ItemsAnyAvailableAndNotRestricted function is checking whether an >item can be checked out and it incorrectly only checks the positive >notforloan values when there can be also negative notforloan >values. If notforloan value is not 0 then it means the item cannot be >checked out. In the case of ordered items the value is negative (-1) >and thus before this change the checkout availability was reported >incorrectly. > >To test: > 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t > Notice it fails > 2) Apply this patch > 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t > Notice it passes now. > >To test via Koha sandbox (Alternatively): > 1) Create circ rule with If all unavailable > 2) Create new biblio > 3) Order a new item to the biblio via acquisitions and set the not > for loan value to Ordered / -1 > 4) Notice you cannot place a hold to the biblio > 5) Apply patch > 6) Notice you can now place a hold to the biblio > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 2994ff608b..cc64cc7517 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1368,7 +1368,7 @@ sub ItemsAnyAvailableAndNotRestricted { > # we can return (end the loop) when first one found: > return 1 > unless $i->itemlost >- || $i->notforloan > 0 >+ || $i->notforloan > || $i->withdrawn > || $i->onloan > || IsItemOnHoldAndFound( $i->id ) >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27058
:
113820
|
113821
|
113822
|
113824
|
113825
|
114203
|
114204
|
114210
|
114211
|
117021
|
117780
|
117781
|
117782
|
117855
|
117864
|
117865