@@ -, +, @@ OPAC Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! --- Koha/NewsItem.pm | 8 +++++++- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 7 ++++++- t/db_dependent/Koha/News.t | 9 ++++++++- 3 files changed, 21 insertions(+), 3 deletions(-) --- a/Koha/NewsItem.pm +++ a/Koha/NewsItem.pm @@ -22,6 +22,7 @@ use Modern::Perl; use Carp; use Koha::Database; +use Koha::Patrons; use base qw(Koha::Object); @@ -37,7 +38,12 @@ Koha::NewsItem represents a single piece of news from the opac_news table =cut -=head3 type +sub author { + my ( $self ) = @_; + return Koha::Patron->_new_from_dbic($self->_result->borrowernumber); +} + +=head3 _type =cut --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt +++ a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ -106,7 +106,12 @@
Published on [% koha_new.published_on | $KohaDates %] [% IF ( (newsdisp == 'opac' || newsdisp == 'both') && koha_new.borrowernumber ) %] - by [% koha_new.author_title | html %] [% koha_new.author_firstname | html %] [% koha_new.author_surname | html %] + [% IF news_item %] + [% SET author = koha_new.author %] + by [% author.title | html %] [% author.firstname | html %] [% author.surname | html %] + [% ELSE %] + by [% koha_new.author_title | html %] [% koha_new.author_firstname | html %] [% koha_new.author_surname | html %] + [% END %] [% END %] [% IF ( news_item ) %] • Show all news --- a/t/db_dependent/Koha/News.t +++ a/t/db_dependent/Koha/News.t @@ -19,7 +19,7 @@ use Modern::Perl; -use Test::More tests => 5; +use Test::More tests => 6; use Koha::NewsItem; use Koha::News; @@ -54,5 +54,12 @@ is( $retrieved_news_item_1->content, $new_news_item_1->content, 'The content met $retrieved_news_item_1->delete; is( Koha::News->search->count, $nb_of_news + 1, 'Delete should have deleted the news_item' ); +subtest '->author' => sub { + plan tests => 1; + + my $news_item = $builder->build_object({ class => 'Koha::News' }); + is( ref($news_item->author), 'Koha::Patron', 'Koha::NewsItem->author returns a Koha::Patron object' ); +}; + $schema->storage->txn_rollback; --