From a843c9d6db10a34c63b5fe0cc3837efa89bc303e Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Thu, 17 Dec 2020 09:05:25 +0100 Subject: [PATCH] Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected --- koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js index b4d243cb2c..c25854b619 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js @@ -280,7 +280,7 @@ $( document ).ready( function () { $("#select_all").on("click",function(e){ e.preventDefault(); - $(".dbcolumn_selection").prop("checked", true); + $(".dbcolumn_selection:not(:disabled)").prop("checked", true); }); $("#clear_all").on("click",function(e){ e.preventDefault(); -- 2.29.2