From 124c263eb3641e934216213afb55314c1545c8cf Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 23 Dec 2020 06:35:19 +0000 Subject: [PATCH] Bug 27301: Pass biblionumbers to opac-reserve.pl in one style only This patch forces biblionumbers to be passed to opac-reserve.pl as individual "biblionumber" parameters instead of sending a concatenated string as a "biblionumbers" parameter. Test plan: _Search Results_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Click "Place hold" 4. Click "Confirm hold" 5. Note that holds are made 6. Cancel holds to prepare for next test... _Cart_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to cart 4. Click on "Cart" 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _List_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to new list 4. Click on list 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _Detail page_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Click "Place hold" 3. Click "Confirm hold" 4. Note that holds are made 5. Cancel hold (because you may as well at this point) --- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 5 +---- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 12 +++++----- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 11 ++++++--- koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 15 +++++++++++-- opac/opac-reserve.pl | 26 ++-------------------- 5 files changed, 31 insertions(+), 38 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt index ec4aaf5b03..545c7d96c9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ -159,7 +159,6 @@
-
@@ -178,6 +177,7 @@ [% END %]

[% IF ( bibitemloo.holdable ) %] + @@ -620,7 +620,6 @@ // When 'Place Hold' button is clicked $(".placehold").click(function(){ - var biblionumbers = ""; var selections = ""; [% IF new_reserves_allowed %] @@ -639,7 +638,6 @@ var badBib = null; $(".confirmjs:checked").each(function() { var biblioNum = $(this).val(); - biblionumbers += biblioNum + "/"; selections += biblioNum + "/"; // If required hold note is empty, make it visible @@ -677,7 +675,6 @@ } $("#selections").val(selections); - $("#biblionumbers").val(biblionumbers); return true; }); diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index 26d3db9f8a..1909679f9c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -590,7 +590,6 @@ -

@@ -641,12 +640,12 @@