From b3e5ab9f33fb98418e3b1e6a5c77bf4f2aa54a6a Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 4 Jan 2021 12:23:46 -0300 Subject: [PATCH] Bug 27034: (follow-up) Remove unneeded params tweak As $c->objects->search doesn't consider path params anymore, there's no need to manually tweak the query parameters. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D --- Koha/REST/V1/Holds.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm index ea233ffb32..7d8eb6e813 100644 --- a/Koha/REST/V1/Holds.pm +++ b/Koha/REST/V1/Holds.pm @@ -445,8 +445,6 @@ sub pickup_locations { my $c = shift->openapi->valid_input or return; my $hold_id = $c->validation->param('hold_id'); - # FIXME: We should really skip the path params in $c->objects->search - delete $c->validation->output->{hold_id}; my $hold = Koha::Holds->find( $hold_id, { prefetch => [ 'patron' ] } ); unless ($hold) { -- 2.30.0