From 8b63eb5a380c0429c86b9e6c368530a200d3ae5c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 2 Dec 2020 08:55:38 +0100 Subject: [PATCH] Bug 27130: [alternate] Don't display itemnumber under "File type" section There is no need to have the "File type" section when we attach a cover item to an item (we cannot upload a zip file) This patch removes the fieldset abd adds the itemnumebr to the breadcrumbs and headings. It also adjusts the help text, removing ZIP as an option when uploading for a biblio or item Lastly it adjusts the results page to use a heading to make things a bit clearer Test plan: 1 - Enable 'LocalCoverImages' system preference 2 - Browse to the details page for a record 3 - Under the 'Images' tab click 'Upload' 4 - Note the display includes File type section with a biblionuber input 5 - Upload an image and note the results page 6 - Return to the biblio, this time on the 'Holdings' tab 7 - Click the down arrow next to 'Edit' and choose 'Upload image' 8 - Note the form has a File type section with an itemnumber input 9 - Apply patch 10 - Repeat steps 2-9, making sure changes to page make sense 11 - Note the breadcrumbs have been updated 12 - Confirm you can complete the upload of the cover for an item and that results look as expected --- .../prog/en/modules/tools/upload-images.tt | 28 +++++++++++++--------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt index 592113b93c..1aa8f9def0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt @@ -93,10 +93,10 @@ -
- File type -
    - [% UNLESS itemnumber %] + [% UNLESS itemnumber %] +
    + File type +
    1. [% IF (filetype != 'image' ) %] @@ -122,13 +122,19 @@
    2. - [% ELSE %] - - - - [% END %] -
    -
    +
+
+ [% ELSE %] +
+
    +
  1. + + + +
  2. +
+
+ [% END %]
Options
    -- 2.11.0