From d4d84655c6066771eccead5b842b6202dcff1fe0 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Thu, 2 Aug 2012 16:55:24 +0200 Subject: [PATCH] Bug 7688 follow-up: Small fixes for QA - # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s) in C4::Serials::GetSubscriptionIrregularities - Bad template constructions fixed in serials/subscription-add.tt Signed-off-by: Kyle M Hall --- C4/Serials.pm | 2 +- .../prog/en/modules/serials/subscription-add.tt | 20 +++++++++++++++++--- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 7b7de86..95af5f9 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -1247,7 +1247,7 @@ get the list of irregularities for a subscription sub GetSubscriptionIrregularities { my $subscriptionid = shift; - return undef unless $subscriptionid; + return unless $subscriptionid; my $dbh = C4::Context->dbh; my $query = qq{ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt index bfebddd..7323afb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt @@ -653,7 +653,11 @@ $(document).ready(function() { [% FOREACH subt IN subtype %] - [% END %] @@ -684,7 +692,13 @@ $(document).ready(function() { -- 1.7.2.5