Bugzilla – Attachment 114919 Details for
Bug 19540
opac-reserve does not correctly warn of too_much reserves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19540: Tell the patron why a hold cannot be placed on items
Bug-19540-Tell-the-patron-why-a-hold-cannot-be-pla.patch (text/plain), 3.28 KB, created by
Jonathan Druart
on 2021-01-07 12:48:38 UTC
(
hide
)
Description:
Bug 19540: Tell the patron why a hold cannot be placed on items
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-01-07 12:48:38 UTC
Size:
3.28 KB
patch
obsolete
>From 9975e6c3921b06a5e77032e6d41f0d211230bbe0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 7 Jan 2021 13:44:33 +0100 >Subject: [PATCH] Bug 19540: Tell the patron why a hold cannot be placed on > items > >This patch adds an explanation when a hold cannot be placed, in some situation: >tooManyReserves >tooManyHoldsForThisRecord >tooManyReservesToday >itemAlreadyOnHold >--- > .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 10 +++++++++- > opac/opac-reserve.pl | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index ec4aaf5b03..d195dbd515 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -200,8 +200,16 @@ > [% IF ( bibitemloo.already_reserved ) %] > <div class="alert alert-warning">You have already requested this title.</div> > [% ELSE %] >- [% IF ( bibitemloo.already_patron_possession ) %] >+ [% IF bibitemloo.alreadypossession %] > <div class="alert alert-warning">This title cannot be requested because it's already in your possession.</div> >+ [% ELSIF bibitemloo.tooManyReserves %] >+ <div class="alert alert-warning">This title cannot be requested because you reached the maximum number of holds.</div> >+ [% ELSIF bibitemloo.tooManyHoldsForThisRecord %] >+ <div class="alert alert-warning">This title cannot be requested because you exceeded max holds per record.</div> >+ [% ELSIF bibitemloo.tooManyReservesToday %] >+ <div class="alert alert-warning">This title cannot be requested because you reached the daily hold limit.</div> >+ [% ELSIF bibitemloo.itemAlreadyOnHold %] >+ <div class="alert alert-warning">This title cannot be requested because you already have hold for this item.</div> > [% ELSE %] > [% UNLESS ( bibitemloo.bib_available ) %] > <div class="alert">There are no items that can be placed on hold.</div> >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index b0ed088689..245c6b6001 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -617,7 +617,7 @@ foreach my $biblioNum (@biblionumbers) { > > my $status = CanBookBeReserved( $borrowernumber, $biblioNum )->{status}; > $biblioLoopIter{holdable} &&= $status eq 'OK'; >- $biblioLoopIter{already_patron_possession} = $status eq 'alreadypossession'; >+ $biblioLoopIter{$status} = 1; > > # For multiple holds per record, if a patron has previously placed a hold, > # the patron can only place more holds of the same type. That is, if the >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19540
:
114919
|
134755
|
139286