Bugzilla – Attachment 11496 Details for
Bug 8175
items.materials check logs error or displays incorrectly in details.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8175 - Check for something in materials field fails in catalogue/details.pl
Bug-8175---Check-for-something-in-materials-field-.patch (text/plain), 1.07 KB, created by
Julian Maurice
on 2012-08-09 13:27:04 UTC
(
hide
)
Description:
Bug 8175 - Check for something in materials field fails in catalogue/details.pl
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2012-08-09 13:27:04 UTC
Size:
1.07 KB
patch
obsolete
>From fe8935ba4612b35c5e0766501e7e0caccee9ba6d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 3 Jul 2012 17:13:22 +0800 >Subject: [PATCH] Bug 8175 - Check for something in materials field fails in > catalogue/details.pl > >The intent was clearly to know if the materials column should be >displayed or not. As such, a defined check handles the NULL, 0, and '0' >cases. The string match for /\S/ handles the intent of only displaying >the column if is there is text in the materials field. > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index d110740..51c23c9 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -261,7 +261,7 @@ foreach my $item (@items) { > $analytics_flag=1; > $item->{countanalytics} = $countanalytics; > } >- if ($item->{'materials'} ne ''){ >+ if (defined($item->{'materials'}) && $item->{'materials'} =~ /\S/){ > $materials_flag = 1; > } > push @itemloop, $item; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8175
:
10566
|
10577
|
10620
|
11496
|
11937
|
11956