Bugzilla – Attachment 115092 Details for
Bug 15788
Split borrowers permission into create/edit and delete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15788: Use delete_borrowers permission
Bug-15788-Use-deleteborrowers-permission.patch (text/plain), 3.36 KB, created by
Martin Renvoize
on 2021-01-12 14:27:16 UTC
(
hide
)
Description:
Bug 15788: Use delete_borrowers permission
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2021-01-12 14:27:16 UTC
Size:
3.36 KB
patch
obsolete
>From 70c745955e8a0c4c3857ecf476694f3177d9e0da Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 12 Jan 2021 14:24:41 +0000 >Subject: [PATCH] Bug 15788: Use delete_borrowers permission > >Link the new delete_borrowers sub-permission to the delete actions. > >Test plan >1/ Remove the delete_borrowers permission from a staff user >2/ Check that the user cannot use the 'Delete' option from the members >menu. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 4 +++- > members/deletemem.pl | 4 ++-- > 3 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index bebe5a143c..4600a35d20 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -63,7 +63,7 @@ > [% END %] > [% END %] > >- [% IF CAN_user_borrowers_edit_borrowers %] >+ [% IF CAN_user_borrowers_delete_borrowers %] > <li><a id="deletepatron" href="#">Delete</a></li> > [% ELSE %] > <li class="disabled"><a data-toggle="tooltip" data-placement="left" title="You are not authorized to delete patrons" id="deletepatron" href="#">Delete</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >index 9db8b24bbe..40d6176f99 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js >@@ -26,10 +26,12 @@ $(document).ready(function(){ > searchfield_date_tooltip('_filter'); > }); > >- if( CAN_user_borrowers_edit_borrowers ){ >+ if( CAN_user_borrowers_delete_borrowers ){ > $("#deletepatron").click(function(){ > window.location='/cgi-bin/koha/members/deletemem.pl?member=' + borrowernumber; > }); >+ } >+ if( CAN_user_borrowers_edit_borrowers ){ > $("#renewpatron").click(function(){ > confirm_reregistration(); > $(".btn-group").removeClass("open"); >diff --git a/members/deletemem.pl b/members/deletemem.pl >index 492e00e581..c5277949f1 100755 >--- a/members/deletemem.pl >+++ b/members/deletemem.pl >@@ -42,7 +42,7 @@ my ($template, $loggedinuser, $cookie) > = get_template_and_user({template_name => "members/deletemem.tt", > query => $input, > type => "intranet", >- flagsrequired => {borrowers => 'edit_borrowers'}, >+ flagsrequired => {borrowers => 'delete_borrowers'}, > debug => 1, > }); > >@@ -70,7 +70,7 @@ if ($patron->category->category_type eq "S") { > exit 0; # Exit without error > } > } else { >- unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>'edit_borrowers'})) { >+ unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>'delete_borrowers'})) { > print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE"); > exit 0; # Exit without error > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15788
:
115091
|
115092
|
118865
|
118866
|
118874
|
118875
|
121887
|
121888
|
121889
|
121890