From 2f29fcd9c676430b0992d9c7899535d443385fe1 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 15 Jan 2021 11:00:39 +0000 Subject: [PATCH] Bug 25540: (follow-up) Test defined not true To test: prove -v t/db_dependent/Koha/Biblio.t it succeeds (maybe) add a library that is not a pickup_location prove the test it fails apply the patch prove! it passes! --- misc/maintenance/check_syspref_cache.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/maintenance/check_syspref_cache.pl b/misc/maintenance/check_syspref_cache.pl index 809ecaae05..ac60081389 100755 --- a/misc/maintenance/check_syspref_cache.pl +++ b/misc/maintenance/check_syspref_cache.pl @@ -43,6 +43,6 @@ my $prefs = Koha::Config::SysPrefs->search(); while (my $pref = $prefs->next) { my $var = lc $pref->variable; my $cached_var = $syspref_cache->get_from_cache("syspref_$var"); - next unless $cached_var; + next unless defined $cached_var; #If not defined in cache we will fetch from DB so this case is OK print "$var: value in cache is $cached_var and value in db is ".$pref->value,"\n" unless $cached_var eq $pref->value; } -- 2.11.0