Bugzilla – Attachment 115343 Details for
Bug 20817
Add ability to retain 9xx fields when adding on order item to existing record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20817: Fix QA script issues
Bug-20817-Fix-QA-script-issues.patch (text/plain), 2.74 KB, created by
Kyle M Hall
on 2021-01-19 18:02:12 UTC
(
hide
)
Description:
Bug 20817: Fix QA script issues
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2021-01-19 18:02:12 UTC
Size:
2.74 KB
patch
obsolete
>From d755bbd45552ca7ef174b1d8cd457d8ac3424457 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Jan 2021 12:38:16 -0500 >Subject: [PATCH] Bug 20817: Fix QA script issues > >--- > Koha/Acquisition/Utils.pm | 2 +- > acqui/neworderempty.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Acquisition/Utils.pm b/Koha/Acquisition/Utils.pm >index 608c92eb4f..5b754d1dd0 100644 >--- a/Koha/Acquisition/Utils.pm >+++ b/Koha/Acquisition/Utils.pm >@@ -23,7 +23,7 @@ use C4::Context; > > Koha::Acquisition::Utils - Additional Koha functions for dealing with orders and acquisitions > >-=head1 SUBROUTINES >+=head2 SUBROUTINES > > =head3 GetMarcFieldsToOrderValues($syspref_name, $record, $field_list) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index bc4e7d53de..04da7cdccc 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -693,6 +693,6 @@ sub staged_items_field { > sub _trim { > my $string = shift; > return unless $string; >- $string =~ s/^\s+|\s+$//g >+ $string =~ s/^\s+|\s+$//g; > return $string; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index ef483850f5..c47ed89908 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -340,7 +340,7 @@ > <input class="addItemControl cancel" name="buttonClear" style="cursor:pointer;" onclick="clearItemBlock(this)" value="Clear" type="button"> > <input class="addItemControl" name="buttonPlusMulti" onclick="javascript:this.nextElementSibling.style.display='inline'; return false;" style="cursor:pointer; margin:0 1em;" value="Add multiple items" type="button"> > <span id="add_multiple_copies" style="display:none"> >- <input class="addItemControl" id="multiValue" name="multiValue" placeholder="Number of items to add" type="number"> >+ <input class="addItemControl" id="multiValue" name="multiValue" placeholder="Number of items to add" type="text" inputmode="numeric" pattern="[0-9]*"> > <input class="addItemControl" name="buttonAddMulti"" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,'[% UniqueItemFields | html %]')" value="Add" type="button"> > <div class="dialog message">NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied</div> > </span> >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20817
:
79867
|
80537
|
86711
|
86746
|
105214
|
105215
|
105216
|
105217
|
105218
|
105219
|
115343
|
118371
|
118372
|
118373
|
118374
|
118375
|
118376
|
118377
|
118378
|
122692
|
122834
|
122841
|
122858
|
122861
|
128766
|
128767
|
128768
|
128769
|
128770
|
128771
|
128772
|
128773
|
128774
|
128775
|
128776
|
128777
|
128782
|
128783
|
128785
|
128786
|
128787
|
128788
|
128789
|
128790
|
128791
|
128792
|
128793
|
128794
|
128795
|
128796
|
128797
|
128798
|
131732
|
131733
|
131734
|
131735
|
131736
|
131737
|
131738
|
131739
|
131740
|
131741
|
131742
|
131743
|
131744
|
131745
|
131746
|
131747
|
131748
|
131749
|
142630
|
142631
|
142632
|
142633
|
142634
|
142635
|
142636
|
142637
|
142638
|
142639
|
142640
|
142641
|
142642
|
142643
|
142644
|
142645
|
142646
|
142647
|
142648
|
142649
|
142650
|
142651
|
142829