Bugzilla – Attachment 115456 Details for
Bug 27481
Use Modern::Perl in cataloguing unimarc plugins
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins
Bug-27481Use-ModernPerl-in-cataloguing-unimarc-plu.patch (text/plain), 4.07 KB, created by
Catherine
on 2021-01-20 20:37:39 UTC
(
hide
)
Description:
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins
Filename:
MIME Type:
Creator:
Catherine
Created:
2021-01-20 20:37:39 UTC
Size:
4.07 KB
patch
obsolete
>From 012f267528d1d62861403a56e8ff2e2cf105e0ed Mon Sep 17 00:00:00 2001 >From: Catherine Ma <catherinem2003@gmail.com> >Date: Wed, 20 Jan 2021 03:43:33 +0000 >Subject: [PATCH] Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins > >In this bug Modern::Perl was not used because #use warnings; was a >comment so Modern:: Perl did not apply > >Test plan: >1. Add patch >2. Check use strict; is used in the files below >cataloguing/value_builder/unimarc_field_105.pl >cataloguing/value_builder/unimarc_field_110.pl >cataloguing/value_builder/unimarc_field_120.pl >cataloguing/value_builder/unimarc_field_130.pl >cataloguing/value_builder/unimarc_field_140.pl >cataloguing/value_builder/unimarc_field_225a.pl >cataloguing/value_builder/unimarc_field_4XX.pl > >Sponsored by Catalyst IT >--- > cataloguing/value_builder/unimarc_field_105.pl | 1 - > cataloguing/value_builder/unimarc_field_110.pl | 1 - > cataloguing/value_builder/unimarc_field_120.pl | 1 - > cataloguing/value_builder/unimarc_field_130.pl | 1 - > cataloguing/value_builder/unimarc_field_140.pl | 1 - > cataloguing/value_builder/unimarc_field_225a.pl | 1 - > cataloguing/value_builder/unimarc_field_4XX.pl | 1 - > 7 files changed, 7 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl >index 75b26d26a2..a2fb938ff8 100755 >--- a/cataloguing/value_builder/unimarc_field_105.pl >+++ b/cataloguing/value_builder/unimarc_field_105.pl >@@ -19,7 +19,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >-#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl >index 68fad1379f..85cbfb63d4 100755 >--- a/cataloguing/value_builder/unimarc_field_110.pl >+++ b/cataloguing/value_builder/unimarc_field_110.pl >@@ -19,7 +19,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >-#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl >index 6ee6d0aa19..231ea74454 100755 >--- a/cataloguing/value_builder/unimarc_field_120.pl >+++ b/cataloguing/value_builder/unimarc_field_120.pl >@@ -19,7 +19,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >-#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_130.pl b/cataloguing/value_builder/unimarc_field_130.pl >index 04d0fb9590..1a01524d21 100755 >--- a/cataloguing/value_builder/unimarc_field_130.pl >+++ b/cataloguing/value_builder/unimarc_field_130.pl >@@ -19,7 +19,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >-#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl >index 980dc0914e..9bae860630 100755 >--- a/cataloguing/value_builder/unimarc_field_140.pl >+++ b/cataloguing/value_builder/unimarc_field_140.pl >@@ -19,7 +19,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >-#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl >index a8b39930d4..a988c97acb 100755 >--- a/cataloguing/value_builder/unimarc_field_225a.pl >+++ b/cataloguing/value_builder/unimarc_field_225a.pl >@@ -40,7 +40,6 @@ It need : > =cut > > use strict; >-#use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index 0caebe1bd8..f99544a9e0 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -19,7 +19,6 @@ > > > use strict; >-#use warnings; FIXME - Bug 2505 > > use CGI qw ( -utf8 ); > use C4::Output; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27481
:
115410
| 115456