From 326fc592db4dd8636dac763d83a59375fd35115c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
Date: Tue, 24 Nov 2020 16:17:58 +0200
Subject: [PATCH] Bug 20447: (follow-up) Correctly list all holdings frameworks
 in editor

The Template Toolkit expects a ref to array and we passed the array
instead. It caused the listing of holdings frameworks not to show when
there was more than one holdings framework defined.

To test:
 1) Apply patch
 2) Make 3 copies of the default HLD framework
 3) Go to a biblio page and create new holding
 4) Click Settings in the editor page and notice all 3 frameworks are
    now listed in the drop-down menu
---
 cataloguing/addholding.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cataloguing/addholding.pl b/cataloguing/addholding.pl
index 4827f3cc9f..152de0e902 100755
--- a/cataloguing/addholding.pl
+++ b/cataloguing/addholding.pl
@@ -686,8 +686,9 @@ $template->param(
     author                   => $biblio->author
 );
 
+my @frameworks = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
 $template->param(
-    frameworks => Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }),
+    frameworks => \@frameworks,
     popup => $mode,
     frameworkcode => $frameworkcode,
     itemtype => $frameworkcode,
-- 
2.30.0