From a47a0d1dbce74bd0907ba90a1be7bd5aefd4d50f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 25 Jan 2021 11:30:30 +0000 Subject: [PATCH] Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind --- .../prog/en/modules/suggestion/suggestion.tt | 2023 +++++++++++--------- 1 file changed, 1116 insertions(+), 907 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index a227fc244f..5feda9c041 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -23,945 +23,1154 @@ [% INCLUDE 'doc-head-close.inc' %] [% IF op == 'else' %] - + [% FILTER collapse %] + + [% END %] [% END %] -[% INCLUDE 'header.inc' %] -[% INCLUDE 'cat-search.inc' %] - - -[% IF ( op == 'show' ) %] -
-
-
- - - -
- Bibliographic information -
    - [% IF ( title ) %] -
  1. - Title: - [% IF suggestion.biblionumber %] - [% suggestion.title | html %] - [% ELSE %] - [% title | html %] - [% END %] -
  2. - [% END %] - [% IF ( author ) %] -
  3. - Author: - [% author | html %] -
  4. - [% END %] - [% IF ( copyrightdate ) %] -
  5. - Copyright date: - [% copyrightdate | html %] -
  6. - [% END %] - [% IF ( isbn ) %] -
  7. - ISBN or ISSN or other standard number: - [% isbn | html %] -
  8. - [% END %] - [% IF ( publishercode ) %] -
  9. - Publisher: - [% publishercode | html %] -
  10. - [% END %] - [% IF ( place ) %] -
  11. - Publication place: - [% place | html %] -
  12. - [% END %] - [% IF ( collectiontitle ) %] -
  13. - Collection title: - [% collectiontitle | html %] -
  14. - [% END %] - [% IF ( itemtype ) %] -
  15. - Document type: - [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) | html %] -
  16. - [% END %] - [% IF ( patron_reason_loop ) %] -
  17. Reason for suggestion: - [% FOREACH patron_reason_loo IN patron_reason_loop %] - [% IF patron_reason_loo.authorised_value == patronreason %][% patron_reason_loo.lib | html %][% END %] - [% END %] -
  18. - [% END %] - [% IF ( note ) %] -
  19. - Notes: - [% note | html %] -
  20. - [% END %] -
-
-
Suggestion management -
    -
  1. - Status: - [% SET status_found = 0 %] - [% IF ( STATUS == 'ASKED' ) %] - Pending - [% SET status_found = 1 %] - [% ELSIF ( STATUS == 'ACCEPTED' ) %] - Accepted - [% SET status_found = 1 %] - [% ELSIF ( STATUS == 'CHECKED' ) %] - Checked - [% SET status_found = 1 %] - [% ELSIF ( STATUS == 'REJECTED' ) %] - Rejected - [% SET status_found = 1 %] - [% ELSIF ( STATUS == 'ORDERED' ) %] - Ordered - [% SET status_found = 1 %] - [% ELSIF ( STATUS == 'AVAILABLE' ) %] - Available - [% SET status_found = 1 %] - [% ELSE %] - [% FOREACH s IN SuggestionStatuses %] - [% IF STATUS == s.authorised_value %] - [% s.lib | html %] - [% SET status_found = 1 %] - [% END %] - [% END %] - [% END %] - -
  2. -
  3. - Reason: - [% IF ( reason ) %] - [% AuthorisedValues.GetByCode( 'SUGGEST', reason, 0 ) | html %] - [% END %] -
  4. -
  5. - - - - - - - - - - - - - - - - - - - - - - - - -
     DateBy
    [% tp('purchase suggestion created by', 'Created by:') | html %][% suggesteddate | $KohaDates %] - [% IF ( suggestedby_patron.borrowernumber ) %] - [% suggestedby_patron.surname | html %], [% suggestedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) - [% Branches.GetName( suggestedby_patron.branchcode ) | html %] ([% suggestedby_patron.category.description | html %]) - [% END %] -
    Managed by:[% manageddate | $KohaDates %] - [% IF ( managedby_patron.borrowernumber ) %] - [% managedby_patron.surname | html %], [% managedby_patron.firstname | html %] ([% managedby_patron.cardnumber | html %]) - [% Branches.GetName( managedby_patron.branchcode ) | html %] ([% managedby_patron.category.description | html %]) - [% END %] -
    Accepted on:[% accepteddate | $KohaDates %] - [% IF ( acceptedby_patron.borrowernumber ) %] - [% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% acceptedby_patron.cardnumber | html %]) - [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %]) - [% END %] -
    Last modification on:[% lastmodificationdate | $KohaDates %] - [% IF ( lastmodificationby_patron.borrowernumber ) %] - [% lastmodificationby_patron.surname | html %], [% lastmodificationby_patron.firstname | html %] ([% lastmodificationby_patron.cardnumber | html %]) - [% Branches.GetName( lastmodificationby_patron.branchcode ) | html %] ([% lastmodificationby_patron.category.description | html %]) - [% END %] -
-
-
Acquisition information -
    -
  1. - Library: [% Branches.GetName( branchcode ) | html %] -
  2. -
  3. - Fund: [% budgetname | html %] -
  4. -
  5. - Copies:[% quantity | html %] -
  6. -
  7. - Currency:[% currency | html %] -
  8. -
  9. - Price:[% price | $Price %] -
  10. -
  11. - Total[% total | $Price %] -
  12. -
-
- -
- << Back to suggestions -
- -
-
-
-[% ELSE %] - -[% IF op == 'save' %] -
-
-
-[% ELSE %] -
-
-
-
+ [% INCLUDE 'header.inc' %] + [% INCLUDE 'cat-search.inc' %] -[% END %] - -[% IF op == 'save' %] - [% FOR m IN messages %] -
- [% SWITCH m.code %] - [% CASE 'biblio_exists' %] - A similar document already exists: [% m.title | html %]. Click on "Confirm your suggestion" to ignore this message. - [% CASE 'manager_not_enough_permissions' %] - The manager you selected does not have sufficient permissions. - [% CASE %] - [% m.code | html %] + - [% END %] -
- - - [% IF ( suggestionid ) %] -

Edit purchase suggestion #[% suggestionid | html %]

- - [% ELSE %] -

Enter a new purchase suggestion

- [% END %] -
Bibliographic information
    -
  1. - - - Required -
  2. -
  3. -
  4. -
  5. -
  6. -
  7. -
  8. -
  9. - [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size = 20, default=itemtype %] -
  10. - [% IF patron_reason_loop %] -
  11. - - -
  12. + [% ELSIF ( op == 'show' ) %] + Suggestions › Show suggestion #[% suggestionid | html %] + [% ELSE %] + Suggestions management [% END %] -
  13. -
-
-
Suggestion management -
    - [% IF ( suggestionid ) %] -
  1. - - -
  2. -
  3. - - - - - [% IF other_reason %] - - [% ELSE %] - - [% END %] - Cancel - -
  4. - [% END %] -
  5. - - - - - - - - - - - - - - - - - - - - - -
     DateByAction
    [% INCLUDE 'date-format.inc' %][% IF ( suggestedby_patron.borrowernumber ) %][% suggestedby_patron.surname | html %], [% suggestedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) [% Branches.GetName( suggestedby_patron.branchcode ) | html %] ([% suggestedby_patron.category.description | html %])[% END %] - Set to patron
    [% INCLUDE 'date-format.inc' %][% IF ( acceptedby_patron.borrowernumber ) %][% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])[% END %]
    [% lastmodificationdate | $KohaDates %] - [% IF lastmodificationby_patron %] - [% INCLUDE 'patron-title.inc' patron=lastmodificationby_patron hide_patron_infos_if_needed=1 %] [% Branches.GetName( lastmodificationby_patron.branchcode ) | html %] ([% lastmodificationby_patron.category.description | html %]) - [% END %] -
  6. - -
  7. - - [% INCLUDE 'date-format.inc' %] -
  8. -
  9. - -
    - - You - - [% IF managedby_patron.borrowernumber && logged_in_user.borrowernumber != managedby_patron.borrowernumber %] - | Previously was [% INCLUDE 'patron-title.inc' patron=managedby_patron hide_patron_infos_if_needed=1 %] [% Branches.GetName( managedby_patron.branchcode ) | html %] ([% managedby_patron.category.description | html %]) - [% END %] -
    - Select manager - [% IF managedby_patron.borrowernumber && logged_in_user.borrowernumber != managedby_patron.borrowernumber %] - Keep existing manager - [% END %] - - -
    - - -
    -
  10. -
-
-
Acquisition information
    -
  1. - -
  2. -
  3. - - - -
  4. -
  5. - -
  6. -
  7. - - [% FOREACH c IN currencies %] - - - [% END %] - - -
  8. -
  9. - -
  10. - -
-
-
- - [% IF ( suggestionid ) %] - [% IF ( need_confirm ) %] - - - [% ELSE %] - - [% END %] - Cancel + [% IF ( publishercode ) %] +
  • + Publisher: + [% publishercode | html %] +
  • + [% END %] + [% IF ( place ) %] +
  • + Publication place: + [% place | html %] +
  • + [% END %] + [% IF ( collectiontitle ) %] +
  • + Collection title: + [% collectiontitle | html %] +
  • + [% END %] + [% IF ( itemtype ) %] +
  • + Document type: + [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) | html %] +
  • + [% END %] + [% IF ( patron_reason_loop ) %] +
  • + Reason for suggestion: + [% FOREACH patron_reason_loo IN patron_reason_loop %] + [% IF patron_reason_loo.authorised_value == patronreason %] + [% patron_reason_loo.lib | html %] + [% END %] + [% END %] +
  • + [% END %] + [% IF ( note ) %] +
  • + Notes: + [% note | html %] +
  • + [% END %] + +
    + +
    + Suggestion management +
      +
    1. + Status: + [% SET status_found = 0 %] + [% IF ( STATUS == 'ASKED' ) %] + Pending + [% SET status_found = 1 %] + [% ELSIF ( STATUS == 'ACCEPTED' ) %] + Accepted + [% SET status_found = 1 %] + [% ELSIF ( STATUS == 'CHECKED' ) %] + Checked + [% SET status_found = 1 %] + [% ELSIF ( STATUS == 'REJECTED' ) %] + Rejected + [% SET status_found = 1 %] + [% ELSIF ( STATUS == 'ORDERED' ) %] + Ordered + [% SET status_found = 1 %] + [% ELSIF ( STATUS == 'AVAILABLE' ) %] + Available + [% SET status_found = 1 %] + [% ELSE %] + [% FOREACH s IN SuggestionStatuses %] + [% IF STATUS == s.authorised_value %] + [% s.lib | html %] + [% SET status_found = 1 %] + [% END %] + [% END %] + [% END %] +
    2. +
    3. + Reason: + [% IF ( reason ) %] + [% AuthorisedValues.GetByCode( 'SUGGEST', reason, 0 ) | html %] + [% END %] +
    4. +
    + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
     DateBy
    [% tp('purchase suggestion created by', 'Created by:') | html %][% suggesteddate | $KohaDates %] + [% IF ( suggestedby_patron.borrowernumber ) %] + [% suggestedby_patron.surname | html %], [% suggestedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) + [% Branches.GetName( suggestedby_patron.branchcode ) | html %] ([% suggestedby_patron.category.description | html %]) + [% END %] +
    Managed by:[% manageddate | $KohaDates %] + [% IF ( managedby_patron.borrowernumber ) %] + [% managedby_patron.surname | html %], [% managedby_patron.firstname | html %] ([% managedby_patron.cardnumber | html %]) + [% Branches.GetName( managedby_patron.branchcode ) | html %] ([% managedby_patron.category.description | html %]) + [% END %] +
    Accepted on:[% accepteddate | $KohaDates %] + [% IF ( acceptedby_patron.borrowernumber ) %] + [% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% acceptedby_patron.cardnumber | html %]) + [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %]) + [% END %] +
    Last modification on:[% lastmodificationdate | $KohaDates %] + [% IF ( lastmodificationby_patron.borrowernumber ) %] + [% lastmodificationby_patron.surname | html %], [% lastmodificationby_patron.firstname | html %] ([% lastmodificationby_patron.cardnumber | html %]) + [% Branches.GetName( lastmodificationby_patron.branchcode ) | html %] ([% lastmodificationby_patron.category.description | html %]) + [% END %] +
    +
    + +
    + Acquisition information +
      +
    1. + Library: + [% Branches.GetName( branchcode ) | html %] +
    2. +
    3. + Fund: + [% budgetname | html %] +
    4. +
    5. + Copies: + [% quantity | html %] +
    6. +
    7. + Currency: + [% currency | html %] +
    8. +
    9. + Price: + [% price | $Price %] +
    10. +
    11. + Total + [% total | $Price %] +
    12. +
    +
    + +
    + << Back to suggestions +
    + +
    +
    + [% ELSE # IF op == "show" %] + + [% IF op == 'save' %] +
    +
    +
    [% ELSE %] - [% IF ( need_confirm ) %] - - - [% ELSE %] - - [% END %] - Cancel +
    +
    +
    [% END %] - - -[% END %] - -[% IF op == 'else' %] - - -

    Suggestions management

    - -[% IF ( displayby != "branchcode" ) %] - - -[% END %] - -[% FOR m IN messages %] -
    - [% SWITCH m.code %] - [% CASE 'already_exists' %] - The suggestion has not been added. A suggestion with this title already exists (suggestion #[% m.id | html %]) - [% CASE 'biblio_exists' %] - A similar document already exists: [% m.title | html %]. Click on "Confirm your suggestion" to ignore this message. - [% CASE %] - [% m.code | html %] - [% END %] -
    -[% END %] + [% IF op == 'save' %] + [% FOR m IN messages %] +
    + [% SWITCH m.code %] + [% CASE 'biblio_exists' %] + A similar document already exists: [% m.title | html %]. Click on "Confirm your suggestion" to ignore this message. + [% CASE 'manager_not_enough_permissions' %] + The manager you selected does not have sufficient permissions. + [% CASE %] + [% m.code | html %] + [% END %] +
    + [% END %] -[% UNLESS ( notabs ) %] -
    - -[% END %] - -[% FOREACH suggestion IN suggestions %] -
    - - -[% IF ( suggestion.suggestions_loop ) %] -

    Check all | Uncheck all

    - - - - - - - - - - - - - - - - - - - [% FOREACH suggestions_loo IN suggestion.suggestions_loop %] - - - - - - - - - - - - - - - [% END %] -
     SuggestionSuggested bySuggested onManaged byManaged onLast modification byLast modification onLibraryFundStatus 
    - - - - [% suggestions_loo.title | html %][% IF ( suggestions_loo.author ) %], by [% suggestions_loo.author | html %][% END %] -
    - [% IF ( suggestions_loo.copyrightdate ) %]© [% suggestions_loo.copyrightdate | html %] [% END %] - [% IF ( suggestions_loo.volumedesc ) %]; Volume:[% suggestions_loo.volumedesc | html %] [% END %] - [% IF ( suggestions_loo.isbn ) %]; ISBN: [% suggestions_loo.isbn | html %] [% END %] - [% IF ( suggestions_loo.publishercode ) %]; Published by [% suggestions_loo.publishercode | html %] [% END %] - [% IF ( suggestions_loo.publicationyear ) %]in [% suggestions_loo.publicationyear | html %] [% END %] - [% IF ( suggestions_loo.place ) %]in [% suggestions_loo.place | html %] [% END %] - [% IF ( suggestions_loo.collectiontitle ) %]; [% suggestions_loo.collectiontitle | html %] [% END %] - [% IF ( suggestions_loo.itemtype ) %]; [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %] [% END %]
    - [% IF ( suggestions_loo.note ) %]
    [% suggestions_loo.note | html %]
    [% END %] - [% IF suggestions_loo.archived %]
    Archived[% END %] -
    - [% suggestions_loo.surnamesuggestedby | html %][% IF ( suggestions_loo.firstnamesuggestedby ) %], [% suggestions_loo.firstnamesuggestedby | html %][% END %] [% IF (suggestions_loo.cardnumbersuggestedby ) %]([% suggestions_loo.cardnumbersuggestedby | html %])[% END %] - - [% IF ( suggestions_loo.suggesteddate ) %][% suggestions_loo.suggesteddate | $KohaDates %][% END %] - - [% suggestions_loo.surnamemanagedby | html %][% IF ( suggestions_loo.firstnamemanagedby ) %], [% suggestions_loo.firstnamemanagedby | html %][% END %] - - [% IF ( suggestions_loo.manageddate ) %][% suggestions_loo.manageddate | $KohaDates %][% END %] - - [% suggestions_loo.surnamelastmodificationby | html %][% IF ( suggestions_loo.firstnamelastmodificationby ) %], [% suggestions_loo.firstnamelastmodificationby | html %][% END %] - - [% IF ( suggestions_loo.lastmodificationdate ) %][% suggestions_loo.lastmodificationdate | $KohaDates %][% END %] - - [% Branches.GetName( suggestions_loo.branchcode ) | html %] - - [% suggestions_loo.budget_name | html %] - - [% IF ( suggestions_loo.ASKED ) %] - Pending - [% ELSIF ( suggestions_loo.ACCEPTED ) %] - Accepted - [% ELSIF ( suggestions_loo.ORDERED ) %] - Ordered - [% ELSIF ( suggestions_loo.REJECTED ) %] - Rejected - [% ELSIF ( suggestions_loo.CHECKED ) %] - Checked - [% ELSIF ( suggestions_loo.AVAILABLE ) %] - Available - [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] - [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] - [% ELSE %] - Status unknown - [% END %] - - [% IF ( suggestions_loo.reason ) %] -
    ([% suggestions_loo.reason | html %]) - [% END %] -
    -
    - Edit - -
    -
    - -
    -

    Change selected suggestions

    -
    -
    -
    - - - - - - - - - Cancel - -
    - - - -
    -
    -
    -
    -
    - - [% PROCESS 'av-build-dropbox.inc' name="suggestion_itemtype", category="SUGGEST_FORMAT", size = 20 %] - - -
    -
    -
    -
    -
    -
    - Select manager - - - - -
    +
    + Bibliographic information +
      +
    1. + + + Required +
    2. +
    3. + + +
    4. +
    5. + + +
    6. +
    7. + + +
    8. +
    9. + + +
    10. +
    11. + + +
    12. +
    13. + + +
    14. +
    15. + + [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size = 20, default=itemtype %] +
    16. + [% IF patron_reason_loop %] +
    17. + + +
    18. + [% END # /IF patron_reason_loop %] +
    19. + + +
    20. +
    -
    -
    -
    - - - -
    +
    + Suggestion management +
      + [% IF ( suggestionid ) %] +
    1. + + +
    2. +
    3. + + + + + [% IF other_reason %] + + [% ELSE %] + + [% END %] + Cancel + +
    4. + [% END %] +
    5. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
       DateByAction
      + + + [% INCLUDE 'date-format.inc' %] + + + [% IF ( suggestedby_patron.borrowernumber ) %] + [% suggestedby_patron.surname | html %], [% suggestedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) [% Branches.GetName( suggestedby_patron.branchcode ) | html %] ([% suggestedby_patron.category.description | html %]) + [% END %] + + Set to patron +
      + + + [% INCLUDE 'date-format.inc' %] + + + [% IF ( acceptedby_patron.borrowernumber ) %] + [% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) + [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %]) + [% END %] +
      + + + [% lastmodificationdate | $KohaDates %] + + [% IF lastmodificationby_patron %] + [% INCLUDE 'patron-title.inc' patron=lastmodificationby_patron hide_patron_infos_if_needed=1 %] [% Branches.GetName( lastmodificationby_patron.branchcode ) | html %] ([% lastmodificationby_patron.category.description | html %]) + [% END %] +
      +
    6. +
    7. + + [% INCLUDE 'date-format.inc' %] +
    8. +
    9. + +
      + + You + + [% IF managedby_patron.borrowernumber && logged_in_user.borrowernumber != managedby_patron.borrowernumber %] + | Previously was [% INCLUDE 'patron-title.inc' patron=managedby_patron hide_patron_infos_if_needed=1 %] [% Branches.GetName( managedby_patron.branchcode ) | html %] ([% managedby_patron.category.description | html %]) + [% END %] +
      + Select manager + [% IF managedby_patron.borrowernumber && logged_in_user.borrowernumber != managedby_patron.borrowernumber %] + Keep existing manager + [% END %] + + +
      + + +
      +
    10. +
    -
    - -
    - -[% ELSE %] - No results. -[% END %] - -
    -[% END %] -[% END %] -[% UNLESS op == 'save' %] - [% UNLESS ( op == 'show' ) %] +
    + Acquisition information +
      +
    1. + + +
    2. +
    3. + + + + +
    4. +
    5. + + +
    6. +
    7. + + [% FOREACH c IN currencies %] + + + [% END %] + +
    8. +
    9. + + +
    10. +
    11. + + +
    12. +
    +
    + + + +
    + + [% IF ( suggestionid ) %] + [% IF ( need_confirm ) %] + + + [% ELSE %] + + [% END %] + Cancel + [% ELSE %] + [% IF ( need_confirm ) %] + + + [% ELSE %] + + [% END %] + Cancel + [% END %] +
    + + [% END # /IF op == 'save' %] - -
    + [% IF op == 'else' %] + -
    - -
    -
    - - [% END %] - [% END %] -
    -[% END %] + [% ELSE %] + No results. + [% END # /IF ( suggestion.suggestions_loop ) %] + +
    + [% END # /FOREACH suggestion %] + [% UNLESS ( notabs ) %] +
    + [% END # /UNLESS notabs %] + [% END # /IF op == 'else' %] + + [% UNLESS op == 'save' %] + [% UNLESS ( op == 'show' ) %] +
    + +
    + +
    + [% END # /UNLESS ( op == 'show' ) %] + [% END # /UNLESS op == 'save' %] +
    + + [% END # /IF op == "show" %] [% MACRO jsinclude BLOCK %] [% INCLUDE 'calendar.inc' %] -- 2.11.0