From 53e38c9c6c9f70aa5c615a26ee1c40edeffa8507 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 27 Jan 2021 09:18:45 +0000 Subject: [PATCH] Bug 24850: (QA follow-up) Add more comments To try and clarify the logic here I've added an addition comment to the code. --- Koha/DateUtils.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 09186242ab..882b770c07 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -123,6 +123,9 @@ sub dt_from_string { /xms; # Default to UTC (when 'Z' is passed) for inbound timezone. + # The regex above succeeds for both 'z', 'Z' and '+/-' offset. + # We set tz as though Z was passed by default and then correct it later if an offset is detected + # by the presence fo the variable. $tz = DateTime::TimeZone->new( name => 'UTC' ); } elsif ( $date_format eq 'iso' or $date_format eq 'sql' ) { -- 2.20.1