Bugzilla – Attachment 116384 Details for
Bug 24488
Holds to Pull sometimes shows the wrong 'first patron' details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24488: create a loop to avoid copy paste
Bug-24488-create-a-loop-to-avoid-copy-paste.patch (text/plain), 2.19 KB, created by
Jonathan Druart
on 2021-02-05 10:53:50 UTC
(
hide
)
Description:
Bug 24488: create a loop to avoid copy paste
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-02-05 10:53:50 UTC
Size:
2.19 KB
patch
obsolete
>From d024da6cdf7ffb39d734eb7572e35245b64c09a6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 5 Jan 2021 09:03:31 +0100 >Subject: [PATCH] Bug 24488: create a loop to avoid copy paste > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >JD amended patch: Rename variables >--- > circ/pendingreserves.pl | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index bc7b25b001..e827b89086 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -272,23 +272,22 @@ foreach my $bibnum ( @biblionumbers ){ > } > $hold_info->{itemtypes} = \@res_itemtypes; > >- # get available locations for each biblio >- $hold_info->{locations} = [ uniq map { defined $_->location ? $_->location : () } @$items ]; >- >- # get available callnumbers for each biblio >- $hold_info->{callnumbers} = [ uniq map { defined $_->itemcallnumber ? $_->itemcallnumber : () } @$items ]; >- >- # get available enumchrons for each biblio >- $hold_info->{enumchrons} = [ uniq map { defined $_->enumchron ? $_->enumchron : () } @$items ]; >- >- # get available copynumbers for each biblio >- $hold_info->{copynumbers} = [ uniq map { defined $_->copynumber ? $_->copynumber : () } @$items ]; >- >- # get available barcodes for each biblio >- $hold_info->{barcodes} = [ uniq map { defined $_->barcode ? $_->barcode : () } @$items ]; >- >- # get available holding branches for each biblio >- $hold_info->{holdingbranches} = [ uniq map { defined $_->holdingbranch ? $_->holdingbranch : () } @$items ]; >+ # get available values for each biblio >+ my $fields = { >+ locations => 'location', >+ callnumbers => 'itemcallnumber', >+ enumchrons => 'enumchron', >+ copynumbers => 'copynumber', >+ barcodes => 'barcode', >+ holdingbranches => 'holdingbranch' >+ }; >+ >+ while ( >+ my ( $key, $field ) = each %$fields ) >+ { >+ $hold_info->{$key} = >+ [ uniq map { defined $_->$field ? $_->$field : () } @$items ]; >+ } > > # items available > $hold_info->{items_count} = $items_count; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24488
:
97773
|
106379
|
106882
|
107206
|
107213
|
111341
|
111342
|
111343
|
111347
|
111348
|
111349
|
111350
|
111358
|
111359
|
111360
|
111361
|
111362
|
112815
|
112816
|
112817
|
112818
|
112819
|
113695
|
113696
|
113697
|
113698
|
113699
|
113700
|
113756
|
113757
|
113763
|
113764
|
113774
|
113775
|
113776
|
113777
|
113778
|
113798
|
113829
|
113830
|
113831
|
113832
|
113833
|
113834
|
113835
|
113836
|
113837
|
113838
|
113839
|
113840
|
113841
|
113842
|
113850
|
113851
|
113852
|
113853
|
113854
|
113855
|
113856
|
113857
|
113858
|
113859
|
113860
|
113861
|
113862
|
113863
|
113864
|
114835
|
114836
|
114837
|
114838
|
114839
|
114840
|
114841
|
114842
|
114843
|
114844
|
114845
|
114846
|
114847
|
114848
|
114849
|
114850
|
116362
|
116363
|
116364
|
116365
|
116366
|
116367
|
116368
|
116369
|
116370
|
116371
|
116372
|
116373
|
116374
|
116375
|
116376
|
116377
| 116384