From 48e115677586480907764d1f5dc1a501d80566a0 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 21 Dec 2020 13:22:15 +0000
Subject: [PATCH] Bug 27289: Template tweaks for point of sale page

This patch makes a couple of minor changes to the point of sale page in
order to make it consistent with other pages in the staff interface:

- Buttons inside table cells should have the "btn-xs" class.
- Required fields should have a "required" class and should have a
  "Required" label.

Also changed: Replaced <input type="number"> according to coding
guidelines.

To test, apply the patch and enable the EnablePointOfSale and
UseCashRegisters system preferences if necessary.

- On the Point of Sale page, add some items to purchase. Confirm that
  the "Add" buttons in the "Items for purchase" table and the "Remove"
  buttons in the "This sale" table are correctly sized.

- In the "Collect payment" form, confirm that "Amount tendered" and
  "Cash register" fields are styled red with "Required" text after them.
- Confirm that the "Amount tendered" field will only accept numeric
  input.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../intranet-tmpl/prog/en/modules/pos/pay.tt     | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
index 5d3462fa94..efdea82446 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
@@ -67,7 +67,7 @@
                                     <td>[% invoice.description | html %]</td>
                                     <td>[% invoice.default_amount | $Price %]</td>
                                     <td>
-                                        <button type="button" class="add_button" data-invoice-code="[% invoice.code | html %]" data-invoice-title="[% invoice.description | html %]" data-invoice-price="[% invoice.default_amount | html %]"><i class="fa fa-plus"></i> Add</button>
+                                        <button type="button" class="btn btn-default btn-xs add_button" data-invoice-code="[% invoice.code | html %]" data-invoice-title="[% invoice.description | html %]" data-invoice-price="[% invoice.default_amount | html %]"><i class="fa fa-plus"></i> Add</button>
                                     </td>
                                 </tr>
                             [% END %]
@@ -112,11 +112,12 @@
                         <ol>
                             <li>
                                 <label for="paid">Amount being paid: </label>
-                                <input type="number" min="0.00" max="10000.00" step="0.01" name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]" readonly/>
+                                <input type="text" inputmode="numeric" pattern="[0-9]*" name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]" readonly/>
                             </li>
                             <li>
-                                <label for="collected">Amount tendered: </label>
-                                <input type="number" min="0.00" max="10000.00" step="0.01" name="collected" id="collected" value=""/>
+                                <label for="collected" class="required">Amount tendered: </label>
+                                <input type="text" inputmode="numeric" pattern="[0-9]*" name="collected" id="collected" value="" class="required" required="required" />
+                                <span class="required">Required</span>
                             </li>
                             <li>
                                 <label>Change to give: </label>
@@ -127,11 +128,12 @@
                             [% PROCESS account_payment_types %]
 
                             <li>
-                                <label for="registerid">Cash register: </label>
-                                <select name="registerid" id="registerid">
+                                <label for="registerid" class="required">Cash register: </label>
+                                <select name="registerid" id="registerid" class="required" required="required">
                                     <option id="noregister" disabled selected="selected" value="">-- Select an option--</option>
                                     [% PROCESS options_for_registers %]
                                 </select>
+                                <span class="required">Required</span>
                             </li>
                         </ol>
 
@@ -242,7 +244,7 @@
         defaultPrice.value,
         1,
         null,
-        '<button class="drop" type="button"><i class="fa fa-trash"></i> Remove</button>',
+        '<button class="btn btn-default btn-xs drop" type="button"><i class="fa fa-trash"></i> Remove</button>',
         invoiceCode
         ]
       );
-- 
2.20.1