Bugzilla – Attachment 116390 Details for
Bug 27586
Import patrons script has a confirm switch that doesn't do anything
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27586: Rollback should be before return statement
Bug-27586-Rollback-should-be-before-return-stateme.patch (text/plain), 912 bytes, created by
Kyle M Hall
on 2021-02-05 11:15:29 UTC
(
hide
)
Description:
Bug 27586: Rollback should be before return statement
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2021-02-05 11:15:29 UTC
Size:
912 bytes
patch
obsolete
>From 7d3661d5f35bc8cbdb4a856d0d10f85b25daec91 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 5 Feb 2021 06:15:06 -0500 >Subject: [PATCH] Bug 27586: Rollback should be before return statement > >--- > Koha/Patrons/Import.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index 6f5646a416..03e3b0ad85 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -420,6 +420,8 @@ sub import_patrons { > } > } > >+ $schema->storage->txn_rollback if $dry_run; >+ > return { > feedback => \@feedback, > errors => \@errors, >@@ -429,8 +431,6 @@ sub import_patrons { > invalid => $invalid, > imported_borrowers => \@imported_borrowers, > }; >- >- $schema->storage->txn_rollback if $dry_run; > } > > =head2 prepare_columns >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27586
:
116179
|
116338
|
116390
|
116452
|
116453