From 1b9acf345bfb9ad477ae11493ab72764760bea2c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 8 Feb 2021 15:46:35 +0100 Subject: [PATCH] Bug 24850: (follow-up) Add tests for invalid RFC3339 dates Make this failure explicit, otherwise we get a "bad plan" failure. --- t/DateUtils.t | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/t/DateUtils.t b/t/DateUtils.t index e3fae041df..8f07612e87 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -137,12 +137,10 @@ cmp_ok( $dt0->epoch(), 'eq', '1325462399', 'dt_from_string handles seconds with $dt0 = dt_from_string( '2012-01-01T23:59:59.999+02:00', 'rfc3339' ); cmp_ok( $dt0->epoch(), 'eq', '1325455199', 'dt_from_string handles seconds with 3 decimal places and a timezone' ); -try { +eval { $dt0 = dt_from_string( '2012-01-01T23:59:59.999Z+02:00', 'rfc3339' ); -} -catch { - like( $_, qr/.*does not match the date format \(rfc3339\).*/, 'dt_from_string should die when passed a bad date string' ); }; +like( $@, qr/.*does not match the date format \(rfc3339\).*/, 'dt_from_string should die when passed a bad date string' ); # Return undef if passed mysql 0 dates $dt0 = dt_from_string( '0000-00-00', 'iso' ); -- 2.20.1