From d740ade7973c95d86afeb8eeeff366a5573fae77 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 23 Nov 2020 15:52:56 +0100 Subject: [PATCH] Bug 27071: Code simplification Signed-off-by: Tomas Cohen Arazi --- C4/Reserves.pm | 4 ++-- Koha/Library.pm | 18 ++---------------- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index a658646407c..515659fd050 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -566,10 +566,10 @@ sub CanItemBeReserved { unless ($item->can_be_transferred({ to => $destination })) { return { status => 'cannotBeTransferred' }; } - unless ($branchitemrule->{hold_fulfillment_policy} ne 'holdgroup' || $item_library->validate_hold_sibling( {branchcode => $pickup_branchcode} )) { + if ($branchitemrule->{hold_fulfillment_policy} eq 'holdgroup' && !$item_library->validate_hold_sibling( {branchcode => $pickup_branchcode} )) { return { status => 'pickupNotInHoldGroup' }; } - unless ($branchitemrule->{hold_fulfillment_policy} ne 'patrongroup' || Koha::Libraries->find({branchcode => $borrower->{branchcode}})->validate_hold_sibling({branchcode => $pickup_branchcode})) { + if ($branchitemrule->{hold_fulfillment_policy} eq 'patrongroup' && !Koha::Libraries->find({branchcode => $borrower->{branchcode}})->validate_hold_sibling({branchcode => $pickup_branchcode})) { return { status => 'pickupNotInHoldGroup' }; } } diff --git a/Koha/Library.pm b/Koha/Library.pm index 19cbcb0121e..27e6b455880 100644 --- a/Koha/Library.pm +++ b/Koha/Library.pm @@ -240,23 +240,9 @@ Return if given library is a valid hold group member sub validate_hold_sibling { my ( $self, $params ) = @_; + my $branchcode = $params->{branchcode}; my @hold_libraries = $self->get_hold_libraries; - - foreach (@hold_libraries) { - my $hold_library = $_; - my $is_valid = 0; - foreach my $key (keys %$params) { - if ($hold_library->$key eq $params->{$key}) { - $is_valid=1; - last; - } - } - if($is_valid) { - #Found one library that meets all search parameters - return 1; - } - } - return 0; + return grep {$_->branchcode eq $branchcode} @hold_libraries; } =head2 Internal methods -- 2.30.0