From 919687eb422cd808db01094e2a596dc11dde9597 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 16 Nov 2020 12:16:50 -0500 Subject: [PATCH] Bug 26633: (QA follow-up) Add error handling for loading transfer limits table --- .../prog/en/modules/admin/transfer_limits.tt | 33 ++++++++++++------- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt index 75a4512333..9b66c30c89 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt @@ -429,19 +429,28 @@ if (val) { $('#loading_limits').show(); - $.getJSON(url, function(data) { - $(".limit-checkboxes").attr("disabled", false); - $(".limit-checkboxes").attr("checked", true); - $(".limit-checkboxes").data('limit_id', null); - - for (var i = 0; i < data.length; i++) { - let limit = data[i]; - let checkbox = $(`#limit-${limit.from_library_id}-${limit.to_library_id}`); - checkbox.attr('checked', false); - checkbox.data('limit_id', limit.limit_id); + $.ajax({ + dataType: "json", + url: url, + success: function(data) { + $(".limit-checkboxes").attr("disabled", false); + $(".limit-checkboxes").attr("checked", true); + $(".limit-checkboxes").data('limit_id', null); + + for (var i = 0; i < data.length; i++) { + let limit = data[i]; + let checkbox = $(`#limit-${limit.from_library_id}-${limit.to_library_id}`); + checkbox.attr('checked', false); + checkbox.data('limit_id', limit.limit_id); + } + }, + complete: function() { + $('#loading_limits').hide(); + }, + error: function(xhr, status, error) { + var errorMessage = xhr.status + ': ' + xhr.statusText + alert('Error - ' + errorMessage); } - - $('#loading_limits').hide(); }); } } -- 2.24.1 (Apple Git-126)