Bugzilla – Attachment 116769 Details for
Bug 27683
Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27683: Impact on catalogue/detail.pl
Bug-27683-Impact-on-cataloguedetailpl.patch (text/plain), 1.31 KB, created by
Fridolin Somers
on 2021-02-11 15:34:38 UTC
(
hide
)
Description:
Bug 27683: Impact on catalogue/detail.pl
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2021-02-11 15:34:38 UTC
Size:
1.31 KB
patch
obsolete
>From d119c3aa664cfa0f125a31476f7f501a4cf9412c Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 11 Feb 2021 16:27:54 +0100 >Subject: [PATCH] Bug 27683: Impact on catalogue/detail.pl > >Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove >test in catalogue/detail.pl. > >Test plan : >1) Build an item and a linked analytical record with 773$0 and $9 >2) Go to record detail page >3) Enable EasyAnalyticalRecords >4) You see analytics tab and analytical count on item >5) Disable EasyAnalyticalRecords >6) You dont see analytics tab >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index 9cb607b1e1..5dc661a06b 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -381,7 +381,7 @@ foreach my $item (@items) { > if ( $analyze ) { > # count if item is used in analytical bibliorecords > # The 'countanalytics' flag is only used in the templates if analyze is set >- my $countanalytics = C4::Context->preference('EasyAnalyticalRecords') ? GetAnalyticsCount($item->{itemnumber}) : 0; >+ my $countanalytics = GetAnalyticsCount( $item->{itemnumber} ); > if ($countanalytics > 0){ > $analytics_flag=1; > $item->{countanalytics} = $countanalytics; >-- >2.30.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27683
:
116767
|
116768
|
116769
|
127839
|
127840
|
127841
|
137447
|
137448
|
137449
|
137700
|
137701
|
137702