From d4f2505ace8953fb2b236af2f6bc3305715cda9d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 15 Feb 2021 10:34:15 +0100 Subject: [PATCH] Bug 27706: (bug 24488 follow-up) Fix libraries column filter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From commit 2285c2d65752dcc899d3fdcff634e6927a1cbbf0 Bug 24488: Show correct first patron details on Holds to pull $('select', this).change( function () { - var filter_value = $(this).val(); - holdst.fnFilter( filter_value, 5, true ); + holdst.fnFilter( $(this).child().val(), 5 ); }); This does not make sense, we need to filter on $(this).val(), it's a select element. Test plan: Place some holds Hit the pending holds page Use the "libraries" column filter and confirm that it works correctly Signed-off-by: Andrew Nugged Signed-off-by: Joonas Kylmälä --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt index c4bdf7f901..5909cfdbac 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt @@ -311,7 +311,7 @@ $("#homebranchfilter").each( function () { $(this).html( createSelect( holdst.fnGetColumnData(5) ) ); $('select', this).change( function () { - holdst.fnFilter( $(this).child().val(), 5 ); + holdst.fnFilter( $(this).val(), 5 ); }); }); $("#itemtype-filter").each( function () { -- 2.11.0